Fix duplicate Content-Length handling in DefaultClient#3448
Open
hutiefang76 wants to merge 1 commit into
Open
Conversation
Signed-off-by: hutiefang <hutiefang@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2862.
RequestTemplate.body(...)records the request body length as aContent-Lengthheader.DefaultClient.convertAndSend(...)used that value in two ways for non-compressed request bodies: it kept the length for fixed-length streaming mode and also added it as a normal request property. WithHttpURLConnection, the body/output path can manage the request length itself, so adding the header manually can produce duplicateContent-Lengthvalues when restricted headers are allowed.This change keeps the parsed content length for the existing
disableRequestBuffering/ fixed-length streaming path, but stops addingContent-LengththroughaddRequestProperty(...)for request bodies.Tests:
Note: I used
-Dtoolchain.skip=truelocally because this machine does not have a Maven JDK 8 toolchain configured; the core module still compiled and ran its test suite successfully.