clear response body length after gzip/deflate decode#3445
Open
alhudz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: return a response with
Content-Encoding: gzip(ordeflate) and aContent-Length(the compressed size);response.body().length()then reports that compressed length even though feign has already decompressed the body.Cause:
Http2Client.toFeignResponseandDefaultClient.convertResponsewrap the stream inGZIPInputStream/InflaterInputStreambut keep the on-the-wireContent-Length, so the stale value no longer matches the readable body and still gates theMAX_RESPONSE_BUFFER_SIZEcheck inInvocationContext.disconnectResponseBodyIfNeededthat decides whether to buffer the whole body into abyte[].Fix: report the length as
nullonce a decompressing wrapper is applied, since the decompressed length is unknown per theBody.length()contract. The other clients leave decompression to their underlying library, so only these two build aResponsefrom a manually decompressed stream.