Skip to content

fix: use ResetConfig for RLEnvironment.reset() in validation script#56

Merged
abrichr merged 1 commit intomainfrom
fix/validate-grpo-reset-api
Mar 18, 2026
Merged

fix: use ResetConfig for RLEnvironment.reset() in validation script#56
abrichr merged 1 commit intomainfrom
fix/validate-grpo-reset-api

Conversation

@abrichr
Copy link
Member

@abrichr abrichr commented Mar 17, 2026

Summary

  • validate_grpo_waa.py Phase 2 called env.reset(task_id=...) but RLEnvironment.reset() takes config=ResetConfig(task_id=...)
  • Phases 1-2 now pass against live WAA VM (waa-pool-00)

Test plan

  • Phase 1: connectivity check passed
  • Phase 2: reset + action + reward passed (reward=0.00, screen 1280x720)

🤖 Generated with Claude Code

The validation script called env.reset(task_id=...) but the actual API
is env.reset(config=ResetConfig(task_id=...)). This caused Phase 2 to
fail with TypeError.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@abrichr abrichr merged commit 942a2f3 into main Mar 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant