[JAVA-SPRING,KOTLIN-SPRING] - Enhance pageable validation by adding minSize and minPage constraints; Search also allOf references for constraints and defaults#23694
Open
Picazsoo wants to merge 9 commits intoOpenAPITools:masterfrom
Conversation
…. Search also allOf references for constraints and defaults
Contributor
There was a problem hiding this comment.
1 issue found across 17 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringPageableScanUtils.java">
<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringPageableScanUtils.java:165">
P2: Array schemas without `items` can now NPE here because `ModelUtils.isArraySchema()` does not guarantee `schema.getItems()` is non-null.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functionality implemented in #23575 is a bit incomplete (it is fully functional, but can miss some edge cases). In cases when the
minimum/maximum/defaultvalues live on a schema referenced viaallOf, the validations/defaults fail to generate.This PR fixes the behavior to properly discover the validationminimum/maximumconstraints as well as thedefault.default, the inlinedefaultwins (overrides any value defined deeper in the schema)maximum, the smallestmaximumwins (so ifmaximumin allOf referenced schema is 75 and inlinemaximumis 50, then the resultingmaximumis 50)minimum, the biggestminimumwins (so ifminimumin allOf referenced schema is 100 and inlineminimumis 10, then the resultingminimumis 100)PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Adds minSize and minPage support to pageable validation and resolves page/size constraints and defaults through $ref and allOf. Spring Java and Kotlin now generate @ValidPageable bounds and @PageableDefault values from shared component schemas.
New Features
@ValidPageablesupportsminSizeandminPagein Java and Kotlin; generators emit these when present.Bug Fixes
$ref/allOfwith intersection semantics (smallest max, largest min; inline default wins).@PageableDefaultfromallOfreferences.items; improved array detection in sort enum scanning.Written for commit daa33e0. Summary will update on new commits.