Skip to content

[JAVA][FEIGN] Put back hardcoded HTTP Client but without the performance issue created in 8484. This is fix for 21187#22905

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
sushma3690:master
Feb 6, 2026
Merged

[JAVA][FEIGN] Put back hardcoded HTTP Client but without the performance issue created in 8484. This is fix for 21187#22905
wing328 merged 2 commits intoOpenAPITools:masterfrom
sushma3690:master

Conversation

@sushma3690
Copy link
Contributor

@sushma3690 sushma3690 commented Feb 5, 2026

Fixes #21187

This fix takes care of the performance issue created in #8484 as mentioned in detail in #21085

Context:

  1. [JAVA][FEIGN] Implement unit tests for java-feign client #8484 introduced new client with every invocation of APIClient which caused application throttling in basic performance tests
  2. [JAVA][FEIGN] Removing hardcoded HTTP Client which is causing performance issues #21085 reverted the above change and hence removed the problem
  3. [BUG] [feign-java] default client changed; okhttp vs httpclient5 are now the same? #21187 showed us that there are now consumers leveraging [JAVA][FEIGN] Implement unit tests for java-feign client #8484 already and either want the behavior back or make it explicit that there is no support for httpclient5

This PR fixes all the above problems - has support for all the clients and removes the performance bottlenecks.
Those who need customization can anyway pass custom client through Feign.Builder.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sushma3690
Copy link
Contributor Author

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

@wing328
Copy link
Member

wing328 commented Feb 5, 2026

thanks for the fix

if no feedback from anyone, i'll get it merged over the weekend.

@wing328 wing328 added this to the 7.20.0 milestone Feb 5, 2026
@wing328 wing328 merged commit 459f359 into OpenAPITools:master Feb 6, 2026
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [feign-java] default client changed; okhttp vs httpclient5 are now the same?

2 participants