Fix ClassCastException when allOf array changes to type array

[kamilkrzywanski]

Fixes #887

When a property changes from allOf wrapping an array schema to a direct type: array, the left side stays a ComposedSchema after resolution while the right side is an ArraySchema. Casting both to ArraySchema threw ClassCastException.

Changes:

• copy items when merging composed schemas in addSchema
• use Schema#getItems() in ArraySchemaDiffResult instead of casting
• add regression test from the issue repro

---

Summary by cubic

Fixes a crash when diffing array schemas that change from an allOf-wrapped array to a direct type: array. Prevents ClassCastException and ensures the specs compare equal.

• Bug Fixes
  • Copy items in addSchema when merging composed schemas.
  • Use Schema#getItems() in ArraySchemaDiffResult instead of casting.
  • Strengthen regression: assert no exception and that both specs are equal.

^{Written for commit 99b2f79. Summary will update on new commits.}

[cubic-dev-ai]

All reported issues were addressed across 5 files

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[DrSatyr]

LGTM — the fix is correct and the core suite passes locally against this branch (269 tests, 0 failures).

One note for the record: testDirectArrayToAllOfArrayDoesNotThrow covers the opposite direction but asserts only that no exception is thrown. That direction currently reports a false breaking change (array -> array), which is pre-existing and out of scope here. Tracked in #920 — the test should become assertOpenApiAreEquals once that's fixed.

Thanks for the fix and the regression test!