Implement Jackson3 support and maintain Jackson2 support#117
Open
smals-mavh wants to merge 5 commits intoOpenAPITools:masterfrom
Open
Implement Jackson3 support and maintain Jackson2 support#117smals-mavh wants to merge 5 commits intoOpenAPITools:masterfrom
smals-mavh wants to merge 5 commits intoOpenAPITools:masterfrom
Conversation
There was a problem hiding this comment.
1 issue found across 36 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="pom.xml">
<violation number="1" location="pom.xml:40">
P2: Jackson 3 requires Java 17+, but the build is pinned to Java 8. Adding the Jackson 3 BOM/tools.jackson dependencies will make builds fail with class file version incompatibility unless the toolchain is upgraded or Jackson 3 is isolated.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Author
|
Some extra context:
|
|
I'm waiting this PR to be released because I can't migrate to spring 4 without breaking my app behavior... 💯 |
pvdbosch
suggested changes
Feb 3, 2026
…upport' into implement-jackson3-with-jackson2-support # Conflicts: # .github/workflows/maven_release.yml # .github/workflows/maven_test.yml
|
@wing328 is there any chance that this PR gets merged? This could be useful to add it once |
pvdbosch
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add Jackson 3 support alongside Jackson 2 so JsonNullable works on both runtimes. This introduces a Jackson3 module with serializers/deserializers and refactors the Jackson2 implementation to keep compatibility.
New Features
Refactors
Written for commit cb6dfbf. Summary will update on new commits.