Xlnx add trace buf and update address space#98
Open
tnmysh wants to merge 5 commits intoOpenAMP:mainfrom
Open
Conversation
Collaborator
tnmysh
commented
Mar 13, 2026
tnmysh
commented
- Add trace buffer support
- Update current DDR addresses to match latest system device-tree standards
- fix trivial compiler warning during building matrix multiply demo
- Allow native cmake build
tnmysh
force-pushed
the
xlnx_add_trace_buf_and_update_address_space
branch
from
f6a6178 to
833a6b4
Compare
arnopo
requested changes
Mar 18, 2026
tnmysh
force-pushed
the
xlnx_add_trace_buf_and_update_address_space
branch
from
833a6b4 to
b59ecf4
Compare
arnopo
reviewed
Mar 31, 2026
| collect (APP_INC_DIRS "${CMAKE_CURRENT_SOURCE_DIR}") | ||
|
|
||
| if (EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/${PROJECT_SYSTEM}/gic_init.c") | ||
| collect (APP_COMMON_SOURCES ${PROJECT_SYSTEM}/gic_init.c) |
Collaborator
There was a problem hiding this comment.
s/exampples/examples/ in commit message
That said you can remove examples: as done for other patches
| int32_t len; | ||
| va_list args; | ||
|
|
||
|
|
|
|
||
| #define NUM_TABLE_ENTRIES 1 | ||
| #define NUM_TABLE_ENTRIES 2 | ||
| #define RSC_TRACE_SZ (4*1024) |
Collaborator
There was a problem hiding this comment.
nitpicking. The trace contain char, why not just just
Suggested change
| #define RSC_TRACE_SZ (4*1024) | |
| #define RSC_TRACE_SZ 4096 |
If xlnx toolchain is not used to build demos, then allow building xlnx demos with native cmake build system. Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
platform_info.h was changed to platform_info_common.h, replace it accordingly for echo demo. Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
fix following compiler warning:
warning: passing argument 1 of 'rpmsg_matrix_app' fr
om incompatible pointer type [-Wincompatible-pointer-types]
47 | rpmsg_matrix_app(rpdev, platform);
| ^~~~~
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
As per latest SDT standard AMD-xilinx EDF yocto is released with fixed memory regions for each core to use. Update the default address for cluster-A core0 to use as per this standard. Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
trace buffer is a circular buffer to store logs. Linux remoteproc subsystem creates a debugfs file that can be used to print these logs on linux side. Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
tnmysh
force-pushed
the
xlnx_add_trace_buf_and_update_address_space
branch
from
b59ecf4 to
1e20941
Compare
Collaborator
Author
|
Hi @arnopo, I found bug in this patch series when using internal tools, please do not merge it until next update. Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.