Skip to content

ci: [SDK-4501] add Capacitor option to create-wrapper-prs workflow#34

Merged
fadi-george merged 1 commit into
mainfrom
fadi/sdk-4501
May 8, 2026
Merged

ci: [SDK-4501] add Capacitor option to create-wrapper-prs workflow#34
fadi-george merged 1 commit into
mainfrom
fadi/sdk-4501

Conversation

@fadi-george
Copy link
Copy Markdown
Contributor

Description

Adds a capacitor option to the shared create-wrapper-prs.yml workflow so the Capacitor SDK is included alongside the other wrappers (Cordova, Flutter, React Native, Unity, .NET) when fanning out release PRs from Android/iOS SDK updates.

Details

  • New capacitor: boolean input (default true) on both workflow_dispatch and workflow_call.
  • Added capacitor to the versions job so it pulls the latest stable release from OneSignal/OneSignal-Capacitor-SDK and computes the next bumped version.
  • New capacitor-release job that calls OneSignal/OneSignal-Capacitor-SDK/.github/workflows/create-release-pr.yml@main with capacitor_version, android_version, and ios_version.

The Capacitor SDK's create-release-pr.yml already accepts those inputs via workflow_call, so wiring lines up with the existing pattern used for the other wrappers.

Made with Cursor

@fadi-george fadi-george requested a review from a team as a code owner May 8, 2026 19:27
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mechanical addition that mirrors the existing wrapper SDK pattern.

Extended reasoning...

Overview

This PR adds Capacitor SDK support to the shared create-wrapper-prs.yml workflow. The change adds a new capacitor boolean input (workflow_dispatch + workflow_call), wires Capacitor into the existing versions job's SDK_REPOS map and outputs, and adds a new capacitor-release job that delegates to OneSignal/OneSignal-Capacitor-SDK/.github/workflows/create-release-pr.yml@main.

Security risks

None of note. No new secret handling, no shell injection vectors introduced (the capacitor key is a static string in the SDK_REPOS map). The reusable workflow call follows the exact same secret-passing pattern as the other wrapper jobs.

Level of scrutiny

Low. This is a CI configuration change that mirrors five existing wrapper integrations (Cordova/Flutter/React Native/Unity/.NET) line-for-line. The pattern is well-established within this same file, and the inputs forwarded to the Capacitor reusable workflow (capacitor_version, android_version, ios_version) match the convention used by the other wrappers.

Other factors

The PR description confirms the downstream create-release-pr.yml in the Capacitor repo already accepts these inputs via workflow_call. The bug hunting system found no issues. No outstanding reviewer comments to address.

@fadi-george fadi-george merged commit 84c0efa into main May 8, 2026
3 checks passed
@fadi-george fadi-george deleted the fadi/sdk-4501 branch May 8, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants