ci: [SDK-4501] add Capacitor option to create-wrapper-prs workflow#34
Conversation
There was a problem hiding this comment.
LGTM, mechanical addition that mirrors the existing wrapper SDK pattern.
Extended reasoning...
Overview
This PR adds Capacitor SDK support to the shared create-wrapper-prs.yml workflow. The change adds a new capacitor boolean input (workflow_dispatch + workflow_call), wires Capacitor into the existing versions job's SDK_REPOS map and outputs, and adds a new capacitor-release job that delegates to OneSignal/OneSignal-Capacitor-SDK/.github/workflows/create-release-pr.yml@main.
Security risks
None of note. No new secret handling, no shell injection vectors introduced (the capacitor key is a static string in the SDK_REPOS map). The reusable workflow call follows the exact same secret-passing pattern as the other wrapper jobs.
Level of scrutiny
Low. This is a CI configuration change that mirrors five existing wrapper integrations (Cordova/Flutter/React Native/Unity/.NET) line-for-line. The pattern is well-established within this same file, and the inputs forwarded to the Capacitor reusable workflow (capacitor_version, android_version, ios_version) match the convention used by the other wrappers.
Other factors
The PR description confirms the downstream create-release-pr.yml in the Capacitor repo already accepts these inputs via workflow_call. The bug hunting system found no issues. No outstanding reviewer comments to address.
Description
Adds a
capacitoroption to the sharedcreate-wrapper-prs.ymlworkflow so the Capacitor SDK is included alongside the other wrappers (Cordova, Flutter, React Native, Unity, .NET) when fanning out release PRs from Android/iOS SDK updates.Details
capacitor: booleaninput (defaulttrue) on bothworkflow_dispatchandworkflow_call.capacitorto theversionsjob so it pulls the latest stable release fromOneSignal/OneSignal-Capacitor-SDKand computes the next bumped version.capacitor-releasejob that callsOneSignal/OneSignal-Capacitor-SDK/.github/workflows/create-release-pr.yml@mainwithcapacitor_version,android_version, andios_version.The Capacitor SDK's
create-release-pr.ymlalready accepts those inputs viaworkflow_call, so wiring lines up with the existing pattern used for the other wrappers.Made with Cursor