Skip to content

Sudheesh - Fix: chart visibility issues in Dark Mode- Most Susceptible tools Chart#4754

Merged
one-community merged 4 commits intodevelopmentfrom
Sudheesh-chart-visibility-issue-mostsusceptible-tools-chart
Mar 2, 2026
Merged

Sudheesh - Fix: chart visibility issues in Dark Mode- Most Susceptible tools Chart#4754
one-community merged 4 commits intodevelopmentfrom
Sudheesh-chart-visibility-issue-mostsusceptible-tools-chart

Conversation

@SudheeshTD
Copy link
Copy Markdown
Contributor

@SudheeshTD SudheeshTD commented Jan 23, 2026

Description

image image

Related PRS (if any):

To test this PR you need to checkout the Latest Development PR.

Main changes explained:

  • Implemented Dark Mode in the Tools Most Susceptible to Breakdown
  • Added Module.CSS file

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. go to /mostsusceptibletoolschart
  6. Check if all the components are rendering properly in dark Mode.
  7. Check if the existing components are working in light mode also.

Screenshots or videos of changes:

image image image image image

Note:

Include the information the reviewers need to know.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 23, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit e092800
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/698e78f41a9ce90008519993
😎 Deploy Preview https://deploy-preview-4754--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@SudheeshTD SudheeshTD marked this pull request as ready for review January 23, 2026 05:47
@SudheeshTD SudheeshTD changed the title Fix: Dark mode and the Module.css file implemented Sudheesh - Fix: Dark mode and the Module.css file implemented Jan 23, 2026
JuliaHa0902
JuliaHa0902 previously approved these changes Jan 30, 2026
Copy link
Copy Markdown
Contributor

@JuliaHa0902 JuliaHa0902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the Tools Most Susceptible to Breakdown in dark mode and confirm that the chart display correctly

Image Image

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Feb 1, 2026
Anusha-Gali
Anusha-Gali previously approved these changes Feb 1, 2026
Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sudheesh,

I have reviewed your PR locally and was able to successfully test in in both the modes. I would however like to point out two issues which do appear out of scope of this PR.

  • The link is not protected.
  • When there is no data in chart, a partial ghost chart row appears. Do let me know if you fix it.
4754.mp4

abdel-lall
abdel-lall previously approved these changes Feb 1, 2026
Copy link
Copy Markdown
Contributor

@abdel-lall abdel-lall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Image

sayali-2308
sayali-2308 previously approved these changes Feb 2, 2026
Copy link
Copy Markdown
Contributor

@sayali-2308 sayali-2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Branch: Sudheesh-chart-visibility-issue-mostsusceptible-tools-chart
  • Backend: development branch
  • Tested on: Windows, Chrome
  • Date: January 31, 2026

Dark Mode Testing:

  1. Navigated to /mostsusceptibletoolschart
  2. Chart title "Tools Most Susceptible to Breakdown" - white text, clearly visible
  3. Project dropdown - "All Projects" visible with light text
  4. Date Range display - readable with proper contrast
  5. Start Date and End Date input fields - light text on dark inputs, clearly readable
  6. Apply button - blue, clearly visible
  7. Horizontal bar chart - blue bars display correctly
  8. Y-axis tool labels - all visible in white text (Wrench, Saw, Pliers, Screwdriver)
  9. Percentage values on bars - white text, clearly readable (53%, 52%, 52%, 32%)
  10. X-axis percentage labels - white text (0%, 25%, 50%, 75%, 100%)
  11. Gridlines - subtle dark lines, visible and don't overpower the chart
  12. Background - dark blue-gray with excellent contrast

Light Mode Testing:

  1. Switched to light mode
  2. Chart title - dark text on light background, clearly visible
  3. Project dropdown - light background with dark text
  4. Date Range - readable
  5. Chart displays correctly with 6 tools (Drill 65%, Hammer 56%, Wrench 53%, Saw 52%, Pliers 52%, Screwdriver 32%)
  6. Y-axis labels - dark text, clearly readable
  7. Percentage values - visible on bars
  8. X-axis labels - dark text, clearly readable
  9. Gridlines - light gray, visible with proper contrast
  10. Background - light/white with excellent contrast

Functionality:

  • Date range picker works correctly
  • Project dropdown functional
  • Chart renders properly in both themes
  • Data displays accurately
  • No console errors observed

naiduajaykumar
naiduajaykumar previously approved these changes Feb 5, 2026
Copy link
Copy Markdown
Contributor

@naiduajaykumar naiduajaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is perfect, implemented all requirements. Ready to merge.

Screenshot 2026-02-05 144233 Screenshot 2026-02-05 144247 Screenshot 2026-02-05 144302 Screenshot 2026-02-05 144352

saitejakaasoju
saitejakaasoju previously approved these changes Feb 6, 2026
Copy link
Copy Markdown
Contributor

@saitejakaasoju saitejakaasoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sudheesh,
I reviewed this PR locally and tested it in both light and dark modes. The Tools Most Susceptible to Breakdown chart looks good and renders correctly.

Image Image

rohanrastogi311
rohanrastogi311 previously approved these changes Feb 6, 2026
Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sudheesh,

Well done with this implementation.

Image Image

@sonarqubecloud
Copy link
Copy Markdown

@SudheeshTD SudheeshTD added the Updated This PR has been updated with a new feature label Feb 24, 2026
@SudheeshTD SudheeshTD changed the title Sudheesh - Fix: Dark mode and the Module.css file implemented Sudheesh - Fix: chart visibility issues in Dark Mode Feb 26, 2026
@SudheeshTD SudheeshTD changed the title Sudheesh - Fix: chart visibility issues in Dark Mode Sudheesh - Fix: chart visibility issues in Dark Mode- Most Susceptible tools Chart Feb 26, 2026
Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sudheesh,

I reviewed this PR locally and tested it in both light and dark modes. The implementation works as expected, and everything renders correctly across both themes.

Image Image Image Image Image Image

Copy link
Copy Markdown

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sudheesh,

I have reviewed your PR locally and thanks for fixing the issues. It works as per requirements.

Image Image Image

Copy link
Copy Markdown

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sudheesh,

Well done with this implementation.

PR 4754 Screenshot 2 PR 4754 Screenshot

@one-community
Copy link
Copy Markdown
Member

Thank you all, merging!

@one-community one-community merged commit efbe106 into development Mar 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible Updated This PR has been updated with a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants