Implement Cross-Platform PDF Generation without MS Word dependency#2111
Implement Cross-Platform PDF Generation without MS Word dependency#2111sydseter merged 6 commits intoOWASP:masterfrom
Conversation
sydseter
left a comment
There was a problem hiding this comment.
Have a look at my comments. Thank you for your efforts!
|
Remember to make sure you run the tests before pushing your commits. |
|
nc |
|
Hi @sydseter , Please review my PR and let me know if any further changes are needed. |
|
I will need some time to test it out. I'll get back to you. |
|
This works quite well. It would be great if we also could do a couple of the following things:
|
|
Yes, that makes sense. I’ll add LibreOffice installation instructions to scripts/README.md |
|
Hi @sydseter , Take a final look ,I have updated LibreOffice installation instructions . Let me know if any further changes are needed. |
|
@abhijit9040 some of your commits aren’t signed. Could you do a git reset and recommit using git commit signing? |
…elines - Resolved cyclomatic complexity and mypy errors in scripts/convert.py. - Added LibreOffice installation instructions to scripts/README.md. - Added Abhijit Sahoo to the volunteer contributor list. - Improved GitHub Actions workflows for PR artifact commenting and secure checkout. - Reverted unintentional changes to copi.owasp.org/Dockerfile as per feedback.
|
The conflicts are due to recent upstream changes . I’ll push an update shortly. |
Key Changes
PDF Conversion Engine:-
Template Migration:-
Script Robustness:-
Cleanup and Performance:-
Issue:-#2110 – Implement Cross-Platform PDF Generation without MS Word dependency
