Repository navigation
Conversation
07ada03 to
7b07026
Compare
7b07026 to
e6028fd
Compare
|
@OCA/core-maintainers |
|
@SirPyTech Do you have studied the possibility to add the |
|
This PR has the |
| to accommodate it to this circumstance. | ||
|
|
||
| You can also take a look at the project \ | ||
| https://github.com/OCA/odoo-module-migrator/ to make the migration process easier. |
There was a problem hiding this comment.
Because I though https://github.com/OCA/oca-port/ was only to port spare missing commits instead of a whole module.
Now I see it can migrate whole modules too (https://github.com/OCA/oca-port/#migrate), somehow leveraging https://github.com/OCA/odoo-module-migrator/ by the way.
Anyway I added it 👍
e6028fd to
84ed0a3
Compare
Thanks for having a look! |
hbrunn
left a comment
hbrunn
left a comment
There was a problem hiding this comment.
...but given you detect which module is added anyways, wouldn't it be great if the bot writes
/ocabot migration $module
too? I think it has write permissions, so this should actually work.
I can imagine some other stuff I'd like to see eventually, like actually enforcing all of the module's commits exist in the PR, but that would be future extensions I think.
| new_addons_paths = _get_added_modules(org, repo, gh_pr) | ||
| new_addons = map(os.path.basename, new_addons_paths) | ||
| for addon in new_addons: | ||
| module_regex = re.compile(rf"- \[[ x]] {addon}") |
There was a problem hiding this comment.
| module_regex = re.compile(rf"- \[[ x]] {addon}") | |
| module_regex = re.compile(rf"- \[[ x]] {addon}\b") |
so as not to confuse sale and sale_stock
|
Hi @hbrunn. Your command failed:
Ocabot commands
More information
|
| gh_migration_issue = _find_issue(gh_repo, milestone, target_branch) | ||
|
|
||
| # The PR is mentioned in the migration issue | ||
| pr_regex = re.compile(rf"#({gh_pr.number})") |
There was a problem hiding this comment.
| pr_regex = re.compile(rf"#({gh_pr.number})") | |
| pr_regex = re.compile(rf"#({gh_pr.number})\b") |
see above
this could save a lot of time for PSC ! 👍 if it's possible easily. |
7 participants
Superseding #220 because https://github.com/SirTakobi is no more active.