#3948 update get work packages endpoints#4005
Open
patriots1 wants to merge 7 commits intofeature/global-car-filteringfrom
Open
#3948 update get work packages endpoints#4005patriots1 wants to merge 7 commits intofeature/global-car-filteringfrom
patriots1 wants to merge 7 commits intofeature/global-car-filteringfrom
Conversation
include optional car param for getAllWorkPackages and getManyWorkPackages
enable support of optional car param with getAllWorkPackages and getManyWorkPackages
add optional car param to more methods
make sure optional car param is used
include checks for optional car param
Steph375
reviewed
Mar 6, 2026
Contributor
Steph375
left a comment
Steph375
left a comment
There was a problem hiding this comment.
I just added middleware that sets req.currentCar based on the carId header from the global car filter. Because of that, controllers shouldn't read carId from the request body anymore.
This endpoint can use req.currentCar?.carId instead so it stays consistent with the rest of the controllers. I would look at getAllProjects its doing something similar.
…Packages-Endpoints
update controller for middleware, fix bug due to type change in service
Contributor
Author
|
Refactored controller to match middleware. Service logic was buggy due to changing the type of carId - fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added optional car parameter for filtering to getAllWorkPackages, getManyWorkPackages, getBlockingWorkPackages and getHomePageWorkPackages.
Test Cases
Unable to test due to issues with local machine. Unit test file for work-packages did not exist.
To Do
Closes #3948