Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves C# code generation correctness for string escaping (notably backslashes) and adds coverage to ensure generated output compiles even when the consuming project disables implicit usings.
Changes:
- Introduces a centralized C# string literal escaping helper and uses it for enum member names, JSON property names, and string defaults.
- Updates generated file headers to include explicit
usingdirectives to avoid relying on consuming-project implicit usings. - Adds new integration-style tests for backslash escaping and for compiling generated code with
ImplicitUsings=disable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/OpenApiCodeGenerator.Tests/CSharpSchemaGeneratorTests.cs | Adds compilation harness helper plus new round-trip tests covering backslash escaping and a compile-only test with implicit usings disabled. |
| src/OpenApiCodeGenerator/CSharpCodeEmitter.cs | Adds EscapeCSharpStringLiteral and applies it in emitted attributes/defaults; emits explicit using directives in generated output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/Nikcio-labs/openapi-code-generator/sessions/5440140b-faab-4f49-9e7d-a24c6f035790 Co-authored-by: nikcio <24605285+nikcio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usingdirectives conditionally)NeedsSystemNamespace()helper using schema-format inspectionNeedsCollectionsNamespace()helper using schema-type inspectionNeedsGlobalizationNamespace()helper checking date format + default valueSchemaResolvesToSystemType()andSchemaResolvesToCollectionType()static helpersEmit()to conditionally emit using directives (restore original flags for System.IO and System.Text.Json)