-
Notifications
You must be signed in to change notification settings - Fork 164
Add support for --split-compile and --jobserver in build.sh #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rapids-bot
merged 10 commits into
NVIDIA:release/26.02
from
aliceb-nv:build-script-splitcompile
Jan 26, 2026
+31
−2
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1f4a0e0
build script changes
aliceb-nv 970ccc4
fix CI build
aliceb-nv a111bf6
address rewview comment
aliceb-nv a7ed7a7
review comment
aliceb-nv e0d89ac
Merge branch 'main' into build-script-splitcompile
aliceb-nv bce1494
address review comments
aliceb-nv da9e76f
Merge branch 'main' into build-script-splitcompile
aliceb-nv 3159ab1
update copyrights
aliceb-nv 14d9f4e
version check for jobserver option
aliceb-nv 0aeb417
Merge branch 'main' into build-script-splitcompile
aliceb-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| # Makefile | ||
|
|
||
| LIBCUOPT_BUILD_DIR ?= cpp/build | ||
| VERBOSE_FLAG ?= | ||
| PARALLEL_LEVEL ?= | ||
|
|
||
| .PHONY: all ninja-build | ||
|
|
||
| all: ninja-build | ||
|
|
||
| ninja-build: | ||
| cmake --build $(LIBCUOPT_BUILD_DIR) $(VERBOSE_FLAG) $(if $(PARALLEL_LEVEL),-j$(PARALLEL_LEVEL),) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a
hasArgfunction doing this:cuopt/build.sh
Lines 97 to 99 in 7543358
Using that might make this a bit easier to read, would you consider it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And actually instead of doing all this command-line parsing and needing to care about spellings like
-j2,-j 2,-j=2etc. I think you might find it easier to just allow the shell variablePARALLEL_LEVELto be overridden by an environment variable, likecudfdoes:PARALLEL_LEVEL=${PARALLEL_LEVEL:=$(nproc)}(cudf build.sh)
Would you consider that?
And in CI if you explicitly want to use GNU Make, you could override it here:
cuopt/ci/build_cpp.sh
Line 13 in 7543358
With
CMAKE_GENERATOR="Unix Makefiles"docs: https://cmake.org/cmake/help/latest/manual/cmake-generators.7.html#makefile-generators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shell variable override approach sounds good, thanks for the suggestion! Will implement it.