Skip to content

[#11203][feat] AutoDeploy: Improve detect_sharding transform time#11161

Closed
taylor-yb-lee wants to merge 1 commit intoNVIDIA:mainfrom
nv-auto-deploy:taylor/optimize_sharding_time
Closed

[#11203][feat] AutoDeploy: Improve detect_sharding transform time#11161
taylor-yb-lee wants to merge 1 commit intoNVIDIA:mainfrom
nv-auto-deploy:taylor/optimize_sharding_time

Conversation

@taylor-yb-lee
Copy link
Copy Markdown
Collaborator

@taylor-yb-lee taylor-yb-lee commented Jan 31, 2026

Description

detect_sharding transform in AutoDeploy backend is very slow for large models (e.g., Nemotron SuperV3 : 6min)
This PR improves detect_sharding processing time by caching weight shapes. By result, Nemotron SuperV3 detect sharding can be done in 88 sec.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Summary by CodeRabbit

  • Refactor
    • Improved efficiency of the auto-deployment transformation process through enhanced shape data handling.

Signed-off-by: Taylor Yeonbok Lee <249374542+taylor-yb-lee@users.noreply.github.com>
@taylor-yb-lee taylor-yb-lee force-pushed the taylor/optimize_sharding_time branch from 4a621ec to 98872d1 Compare February 2, 2026 23:45
@taylor-yb-lee taylor-yb-lee changed the title [feat][WIP] improve sharding time [#11203][feat] Improve auto-deploy sharding time Feb 2, 2026
@taylor-yb-lee taylor-yb-lee changed the title [#11203][feat] Improve auto-deploy sharding time [#11203][feat] Improve auto-deploy detect_sharding time Feb 2, 2026
@taylor-yb-lee taylor-yb-lee marked this pull request as ready for review February 2, 2026 23:48
@taylor-yb-lee taylor-yb-lee requested a review from a team as a code owner February 2, 2026 23:48
@taylor-yb-lee taylor-yb-lee linked an issue Feb 2, 2026 that may be closed by this pull request
1 task
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

A context manager shape_cache_scope() is introduced to manage shape caching during node processing. The sharding module is refactored to use this context manager, wrapping sharding source processing (factory, manual, heuristic) within the scoped block to localize cache lifecycle management.

Changes

Cohort / File(s) Summary
New Shape Cache Mechanism
tensorrt_llm/_torch/auto_deploy/utils/node_utils.py
Added module-level caches (_param_names_cache, _weight_shape_cache) and _cache_enabled flag. Implemented shape_cache_scope() context manager to enable/disable caching and clear caches on exit. Integrated caching into extract_weight_nodes() and get_weight_shape() functions, with cache population on compute and reuse when enabled.
Sharding Source Refactoring
tensorrt_llm/_torch/auto_deploy/transform/library/sharding.py
Reorganized sharding source processing loop to wrap factory, manual, and heuristic source handling inside shape_cache_scope() context manager. Replaced direct conditional branches with centralized control flow calling detect_sharding_from_config() for factory/manual sources while preserving heuristic dimension checks. Added import for shape_cache_scope utility.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description is incomplete and missing critical required sections: Test Coverage is empty, and the PR title format is incorrect. Add a proper PR title following [type] format (e.g., [#11203][feat]), complete the Test Coverage section with relevant test names, and provide more detail on the implementation approach and why the caching strategy was chosen.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly describes the main optimization—improving detect_sharding transform time via caching, which directly matches the core changes (shape_cache_scope context manager and weight shape caching).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@taylor-yb-lee taylor-yb-lee changed the title [#11203][feat] Improve auto-deploy detect_sharding time [#11203][feat] AutoDeploy: Improve detect_sharding transform time Feb 3, 2026
@taylor-yb-lee taylor-yb-lee changed the title [#11203][feat] AutoDeploy: Improve detect_sharding transform time [#11203][feat] AutoDeploy: Improve detect_sharding transform time [#1234][doc] Update documentation Feb 3, 2026
@taylor-yb-lee taylor-yb-lee changed the title [#11203][feat] AutoDeploy: Improve detect_sharding transform time [#1234][doc] Update documentation [#11203][feat] AutoDeploy: Improve detect_sharding transform time Feb 3, 2026
@taylor-yb-lee taylor-yb-lee changed the title [#11203][feat] AutoDeploy: Improve detect_sharding transform time [#11203][feat] AutoDeploy: Improve detect_sharding transform time Feb 3, 2026
@taylor-yb-lee
Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #34538 [ run ] triggered by Bot. Commit: 98872d1

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #34538 [ run ] completed with state SUCCESS. Commit: 98872d1
/LLM/main/L0_MergeRequest_PR pipeline #26649 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@taylor-yb-lee
Copy link
Copy Markdown
Collaborator Author

/bot run

@taylor-yb-lee taylor-yb-lee added the AutoDeploy <NV> AutoDeploy Backend label Feb 3, 2026
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #34568 [ run ] triggered by Bot. Commit: 98872d1

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #34568 [ run ] completed with state FAILURE. Commit: 98872d1
/LLM/main/L0_MergeRequest_PR pipeline #26676 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@taylor-yb-lee
Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #34682 [ run ] triggered by Bot. Commit: 98872d1

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #34682 [ run ] completed with state SUCCESS. Commit: 98872d1
/LLM/main/L0_MergeRequest_PR pipeline #26763 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@taylor-yb-lee
Copy link
Copy Markdown
Collaborator Author

Replace with #11250

@taylor-yb-lee taylor-yb-lee deleted the taylor/optimize_sharding_time branch February 14, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoDeploy <NV> AutoDeploy Backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: AutoDeploy : Improve detect_sharding transform processing time

3 participants