Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
shiju-nv
force-pushed
the
feat/cli-profile-commands
branch
from
September 15, 2026 07:16
e868727 to
b9b64f1
Compare
shiju-nv
marked this pull request as ready for review
September 15, 2026 07:17
shiju-nv
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 15, 2026 07:17
Contributor
|
thanks for the pr, #3068 has been closed as stale fyi |
Collaborator
BlockedGator is blocked because GitHub reports that this branch has merge conflicts with Next action: @shiju-nv, please update the branch from Gator metadata
|
shiju-nv
force-pushed
the
feat/cli-profile-commands
branch
3 times, most recently
from
September 18, 2026 19:03
652fe9b to
cfe00bb
Compare
Add profile discovery and management commands with shared handlers for the existing provider entry points. List a flat catalog across scopes and follow continuation tokens through full and short pages. Describe metadata, credentials, endpoints, TLS inspection, and MCP access settings while preserving complete JSON/YAML definitions. Cover parser equivalence, scope forwarding, pagination, and inspection settings with focused unit and compiled-CLI integration tests. Update docs, public skills, examples, and E2E command invocations. Refs NVIDIA#2588 Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
force-pushed
the
feat/cli-profile-commands
branch
from
September 18, 2026 19:25
cfe00bb to
24a53a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Profiles are currently split between
provider list-profilesandprovider profile, with no human-readable view of a single definition. This addsopenshell profilefor discovery and management, includingdescribe, while retaining the existing nested commands through shared handlers.Related Issue
Closes #2588.
Related implementation: #3068. Both proposals support the legacy commands.
Changes
profile list,describe,export,import,update,lint, anddelete, with a validated--type providerfilter for listing.provider list-profilesandprovider profile …, including their arguments, output options, and workspace/global flags. Both entry points use the same execution handlers.NAME / TYPE / CATEGORY / SOURCE / SCOPElist and follow the gateway's continuation tokens through full or short pages, preserving same-name entries across scopes.Compatibility note: legacy names and flags remain supported, but both list spellings now use the flat human-readable table. The JSON/YAML profile schema is unchanged. Existing import/lint file and directory flags and the update ID/file arguments remain unchanged. No gateway or protobuf API changes are included.
Testing
mise run pre-commitpassesCurrent-main verification: 10 profile library tests and 8 CLI parser tests passed. All 76 tests in the compiled provider integration target passed, including pagination, scope forwarding, structured description/export equivalence, provider readiness, credential refresh, and safe error handling. Pagination coverage includes full terminal pages and multiple short nonterminal pages. Live sandbox E2E was not run for this CLI change.
Tests and the full pre-commit gate passed on main
e38d7254e. The final rebase to903d9a0e7preserves the exact PR patch; the only intervening Rust change is a copyright comment. License, Python, Helm, Markdown, script syntax, and Rust formatting checks were repeated on the final tree.Checklist