Add more Python-related leak suppressions.#6370
Conversation
|
CI MESSAGE: [52651772]: BUILD STARTED |
|
| Filename | Overview |
|---|---|
| qa/leak.sup | Adds Python 3.12 false-positive suppressions, compiler/toolchain path suppressions, and removes two now-covered entries (_PyObject_GC_NewVar/New); yyparse is a bare symbol suppression without a path filter |
| qa/test_template_impl.sh | LD_LIBRARY_PATH now prepends nvjpeg2k and nvtiff deps before nvimgcodec; ASAN_OPTIONS moved after LD_LIBRARY_PATH setup and start_deactivated changed from true to false for full coverage when sanitizers are enabled |
| qa/TL0_cpu_only/test_nofw.sh | Mirrors the test_template_impl.sh LD_LIBRARY_PATH fix: adds nvjpeg2k and nvtiff dep paths before nvimgcodec, and preserves the existing LD_LIBRARY_PATH instead of overwriting it |
| qa/TL0_cpu_only/test_pytorch.sh | Same LD_LIBRARY_PATH fix as test_nofw.sh — consistent with the broader change |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[test_body_wrapper] -->|DALI_ENABLE_SANITIZERS set| B[enable_sanitizer]
B --> C[Set PYTHONMALLOC=malloc]
C --> D[Build libfakeclose.so]
D --> E[Set LD_PRELOAD with libasan]
E --> F[Append nvjpeg2k /lib to LD_LIBRARY_PATH]
F --> G[Append nvtiff /lib to LD_LIBRARY_PATH]
G --> H[Append nvimgcodec dir to LD_LIBRARY_PATH]
H --> I[Export ASAN_OPTIONS start_deactivated=false]
I --> J[Export ASAN_SYMBOLIZER_PATH]
J --> K[test_body runs with full ASAN coverage]
K --> L[disable_sanitizer restore LD_LIBRARY_PATH]
A -->|no sanitizers| M[test_body runs normally]
Reviews (9): Last reviewed commit: "Suppress notebook toolchain sanitizer le..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| export LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:"$(python -c 'import nvidia.nvjpeg2k as n, os; print(os.path.dirname(n.__file__) + "/lib")' 2>/dev/null)" | ||
| export LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:"$(python -c 'import nvidia.nvtiff as n, os; print(os.path.dirname(n.__file__) + "/lib")' 2>/dev/null)" | ||
| export LD_LIBRARY_PATH=${LD_LIBRARY_PATH}:"$(python -c 'import nvidia.nvimgcodec as n, os; print(os.path.dirname(n.__file__))' 2>/dev/null)" |
There was a problem hiding this comment.
enable_sanitizer() use 2>/dev/null without || echo '', while the equivalent lines in test_nofw.sh and test_pytorch.sh use 2>/dev/null || echo ''. Both produce an empty string on failure, so the behaviour is identical, but the inconsistency may surprise a future reader. Consider aligning the style.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
CI MESSAGE: [52651772]: BUILD FAILED |
|
CI MESSAGE: [52687092]: BUILD STARTED |
|
CI MESSAGE: [52701305]: BUILD FAILED |
|
CI MESSAGE: [52702362]: BUILD STARTED |
|
CI MESSAGE: [52752780]: BUILD STARTED |
|
CI MESSAGE: [52702362]: BUILD FAILED |
- After moving to Python 3.12 for the sanitized build, new false positives have started appearing. This requires adding additional suppression entries and modifies sanitizer options. Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [52760946]: BUILD STARTED |
|
CI MESSAGE: [52687092]: BUILD FAILED |
|
CI MESSAGE: [52760946]: BUILD FAILED |
|
CI MESSAGE: [52953311]: BUILD STARTED |
|
CI MESSAGE: [52953745]: BUILD STARTED |
|
CI MESSAGE: [52953745]: BUILD FAILED |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [53052736]: BUILD FAILED |
|
CI MESSAGE: [53053372]: BUILD STARTED |
|
CI MESSAGE: [53053372]: BUILD FAILED |
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [53173151]: BUILD STARTED |
4 participants
new false positives have started appearing. This requires
adding additional suppression entries and modifies sanitizer
options.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
new false positives have started appearing. This requires
adding additional suppression entries.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A