Open
Conversation
Documentation preview |
Contributor
|
Is the new action/job added here specifically for the RAPIDS runner? If so, it should probably say that in the name and file name. |
| - name: Run tests | ||
| run: | | ||
| merlin_branch="${{ steps.get-branch-name.outputs.branch }}" | ||
| MERLIN_BRANCH=$merlin_branch COMPARE_BRANCH=$merlin_branch \ |
Contributor
There was a problem hiding this comment.
These env vars are not required here.
MERLIN_BRANCHis used in other places where we need to install other merlin packages from the equivalent branch ( release branch or development branch). In thistest-gputox environment we only install the core package.- the
get-branch-namestep can also be removed here too since we won't use it ifMERLIN_BRANCHis removed
- the
COMPARE_BRANCHis something currently only used in Merlin Models to inspect the diff and label parts as changed or unchanged (so that tests using TensorFlow only run if the tensorflow code has changed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testing activation of rapids runner.