Skip to content

Fix 4 content bugs in Manage users#688

Merged
frankieroberto merged 5 commits intomainfrom
manage-users-fixes
Mar 3, 2026
Merged

Fix 4 content bugs in Manage users#688
frankieroberto merged 5 commits intomainfrom
manage-users-fixes

Conversation

@frankieroberto
Copy link
Collaborator

These 2 were accidentally not updated when updating the other views.

Thanks to @tomdoughty for spotting! 🤦

These 2 were accidentally not updated when updating the other views.
@frankieroberto frankieroberto changed the title Fix 2 content bugs in Manage users Fix 4 content bugs in Manage users Mar 3, 2026
@frankieroberto frankieroberto temporarily deployed to record-a-vac-manage-use-t5h0pu March 3, 2026 11:06 Inactive
Copy link

@tomdoughty tomdoughty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search box on active page has better margin and spacing on the active page, probably worth changing in case the dev who picks it up copies one of the other ones

@frankieroberto frankieroberto temporarily deployed to record-a-vac-manage-use-t5h0pu March 3, 2026 12:46 Inactive
Copy link
Contributor

@Anna-Sutton Anna-Sutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@frankieroberto frankieroberto temporarily deployed to record-a-vac-manage-use-t5h0pu March 3, 2026 20:31 Inactive
@frankieroberto
Copy link
Collaborator Author

frankieroberto commented Mar 3, 2026

@tomdoughty:

The search box on active page has better margin and spacing on the active page, probably worth changing in case the dev who picks it up copies one of the other ones

Good spot. Fixed in 1ee3488 (which also refactors it into a shared partial).

Use the Nunjucks macro, and refactor into a shared partial.
@frankieroberto frankieroberto temporarily deployed to record-a-vac-manage-use-t5h0pu March 3, 2026 20:38 Inactive
@frankieroberto frankieroberto merged commit 09397c9 into main Mar 3, 2026
1 check passed
@frankieroberto frankieroberto deleted the manage-users-fixes branch March 3, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants