Skip to content

CCM-10536: Clean pipeline overrides for project #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sidnhs merged 3 commits into from
Aug 21, 2026
Merged

CCM-10536: Clean pipeline overrides for project #678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33ad5c0
CCM-10536: Clean pipeline overrides for project
sidnhs Aug 20, 2026
8397416
CCM-10536: Restore executable bit for dispatch script
sidnhs Aug 21, 2026
c494c8a
CCM-10536: Script execution
sidnhs Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .github/scripts/dispatch_internal_repo_workflow.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
# --terraformAction <action> \
# --internalRef <ref> \
# --overrides <overrides> \
# --overrideProjectName <name> \
# --overrideRoleName <name>

#
Expand All @@ -33,7 +32,6 @@
# --terraformAction "apply" \
# --internalRef "main" \
# --overrides "tf_var=someString" \
# --overrideProjectName nhs \
# --overrideRoleName nhs-service-iam-role \
# --extraSecretNames '["MY_API_KEY"]'

Expand Down Expand Up @@ -82,10 +80,6 @@ while [[ $# -gt 0 ]]; do
overrides="$2"
shift 2
;;
--overrideProjectName) # Override the project name (optional)
overrideProjectName="$2"
shift 2
;;
--overrideRoleName) # Override the role name (optional)
overrideRoleName="$2"
shift 2
Expand Down Expand Up @@ -242,9 +236,7 @@ echo " targetAccountGroup: $targetAccountGroup"
echo " terraformAction: $terraformAction"
echo " internalRef: $internalRef"
echo " overrides: $overrides"
echo " overrideProjectName: $overrideProjectName"
echo " overrideRoleName: $overrideRoleName"
echo " targetProject: $targetProject"
echo " runId: $runId"
echo " buildSandbox: $buildSandbox"
echo " apimEnvironment: $apimEnvironment"
Expand All @@ -263,9 +255,7 @@ DISPATCH_EVENT=$(jq -ncM \
--arg terraformAction "$terraformAction" \
--arg targetWorkflow "$targetWorkflow" \
--arg overrides "$overrides" \
--arg overrideProjectName "$overrideProjectName" \
--arg overrideRoleName "$overrideRoleName" \
--arg targetProject "$targetProject" \
--arg runId "$runId" \
--arg buildSandbox "$buildSandbox" \
--arg apimEnvironment "$apimEnvironment" \
Expand All @@ -280,9 +270,7 @@ DISPATCH_EVENT=$(jq -ncM \
"inputs": (
(if $infraRepoName != "" then { "infraRepoName": $infraRepoName } else {} end) +
(if $terraformAction != "" then { "terraformAction": $terraformAction } else {} end) +
(if $overrideProjectName != "" then { "overrideProjectName": $overrideProjectName } else {} end) +
(if $overrideRoleName != "" then { "overrideRoleName": $overrideRoleName } else {} end) +
(if $targetProject != "" then { "targetProject": $targetProject } else {} end) +
(if $overrides != "" then { "overrides": $overrides } else {} end) +
(if $runId != "" then { "runId": $runId } else {} end) +
(if $buildSandbox != "" then { "buildSandbox": $buildSandbox } else {} end) +
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/pr_destroy_dynamic_env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ jobs:
--targetComponent "api" \
--targetAccountGroup "nhs-notify-supplier-api-dev" \
--terraformAction "destroy" \
--overrideProjectName "nhs" \
--overrideRoleName "nhs-main-acct-supplier-api-github-deploy"

destroy-dynamic-proxy:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/stage-3-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ jobs:
--targetComponent "api" \
--targetAccountGroup "nhs-notify-supplier-api-dev" \
--terraformAction "apply" \
--overrideProjectName "nhs" \
--overrideRoleName "nhs-main-acct-supplier-api-github-deploy"
populate-config:
name: "Populate Supplier Config"
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/stage-4-acceptance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ jobs:
--targetWorkflow "dispatch-contextual-tests-dynamic-env.yaml" \
--infraRepoName "nhs-notify-supplier-api" \
--releaseVersion "${GITHUB_HEAD_REF:-${GITHUB_REF#refs/heads/}}" \
--overrideProjectName "nhs" \
--targetEnvironment "$ENVIRONMENT" \
--targetAccountGroup "nhs-notify-supplier-api-dev" \
--targetComponent "api" \
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,15 @@ New developers of the NHS Notify Supplier API should understand the below.
sso_start_url = https://d-9c67018f89.awsapps.com/start#/
sso_region = eu-west-2
sso_account_id = 820178564574
sso_role_name = nhs-notify-bc-developer
sso_role_name = nhs-notify-developer
region = eu-west-2
output = json

[profile supplier-nonprod]
sso_start_url = https://d-9c67018f89.awsapps.com/start#/
sso_region = eu-west-2
sso_account_id = 885964308133
sso_role_name = nhs-notify-bc-developer
sso_role_name = nhs-notify-developer
region = eu-west-2
output = json
```
Expand Down
Loading