Skip to content

CCM-14600: Enable S3 Access Logging Where Missing#438

Merged
jamesthompson26-nhs merged 1 commit intomainfrom
feature/CCM-14600_Enable_Access_Logging_for_EventCache
Mar 4, 2026
Merged

CCM-14600: Enable S3 Access Logging Where Missing#438
jamesthompson26-nhs merged 1 commit intomainfrom
feature/CCM-14600_Enable_Access_Logging_for_EventCache

Conversation

@jamesthompson26-nhs
Copy link
Contributor

@jamesthompson26-nhs jamesthompson26-nhs commented Mar 3, 2026

Description

Removes old log bucket from app component and redirects or adds s3 access logging where missing, to the acct level bucket.

Context

Pentest flagged this stuff as missing.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@jamesthompson26-nhs jamesthompson26-nhs requested review from a team as code owners March 3, 2026 15:42
@jamesthompson26-nhs jamesthompson26-nhs force-pushed the feature/CCM-14600_Enable_Access_Logging_for_EventCache branch from 2d7bb51 to 80cd30c Compare March 3, 2026 15:48
@jamesthompson26-nhs jamesthompson26-nhs changed the title Feature/ccm 14600 enable access logging for event cache CCM-14600: Enable S3 Access Logging Where Missing Mar 3, 2026
@jamesthompson26-nhs jamesthompson26-nhs merged commit 5875c0d into main Mar 4, 2026
38 checks passed
@jamesthompson26-nhs jamesthompson26-nhs deleted the feature/CCM-14600_Enable_Access_Logging_for_EventCache branch March 4, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants