-
Notifications
You must be signed in to change notification settings - Fork 7
CCM-17641: Reporting failures #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4ac0ba7
3d35b03
e450b8d
146b50b
b1a99c8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,6 +75,6 @@ jobs: | |
| - name: "Checkout code" | ||
| uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5 | ||
| - name: "Build docs" | ||
| uses: NHSDigital/nhs-notify-shared-modules/.github/actions/build-docs@3.0.0 | ||
| uses: NHSDigital/nhs-notify-shared-modules/.github/actions/build-docs@3.1.6 | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Taken version that includes the build documentation fix from NHSDigital/nhs-notify-shared-modules#195. |
||
| with: | ||
| version: "${{ inputs.version }}" | ||
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,12 +8,12 @@ properties: | |
| $ref: ../defs/requests.schema.yaml#/properties/messageReference | ||
| senderId: | ||
| $ref: ../defs/requests.schema.yaml#/properties/senderId | ||
| failureCode: | ||
| $ref: ../defs/core.schema.yaml#/properties/failureCode | ||
| failureReason: | ||
| $ref: ../defs/core.schema.yaml#/properties/failureReason | ||
| reasonCode: | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. taken from #339 |
||
| $ref: ../defs/print.schema.yaml#/properties/reasonCode | ||
| reasonText: | ||
| $ref: ../defs/print.schema.yaml#/properties/reasonText | ||
| required: | ||
| - messageReference | ||
| - senderId | ||
| - failureCode | ||
| - failureReason | ||
| - reasonCode | ||
| - reasonText | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taken for now from Ian's review to give the artifacts different name.