Changed timing of check from before to after message wrapping#1472
Closed
chiaramapellimt wants to merge 1 commit into
Closed
Changed timing of check from before to after message wrapping#1472chiaramapellimt wants to merge 1 commit into
chiaramapellimt wants to merge 1 commit into
Conversation
93d5737 to
6142722
Compare
|
Looks good. All 4 mutations in this change were killed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ticket reference: NIAD-3462
The XML schema validation to is now running after the message is wrapped, instead of before, so that the full
RCMR_IN030000UK06orRCMR_IN030000UK07message is validated against the correct schema, rather than the bare<EhrExtract>fragment which would always fail validation regardless if it’s redaction or not.Why
NME raised an incident related to a failed validation.
Type of change
Please delete options that are not relevant.
Checklist: