Skip to content

Changed timing of check from before to after message wrapping#1472

Closed
chiaramapellimt wants to merge 1 commit into
mainfrom
NIAD-3462
Closed

Changed timing of check from before to after message wrapping#1472
chiaramapellimt wants to merge 1 commit into
mainfrom
NIAD-3462

Conversation

@chiaramapellimt
Copy link
Copy Markdown
Contributor

@chiaramapellimt chiaramapellimt commented May 11, 2026

What

Ticket reference: NIAD-3462

The XML schema validation to is now running after the message is wrapped, instead of before, so that the full RCMR_IN030000UK06 or RCMR_IN030000UK07 message is validated against the correct schema, rather than the bare <EhrExtract> fragment which would always fail validation regardless if it’s redaction or not.

Why

NME raised an incident related to a failed validation.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (non-breaking change with no effect on the functionality affecting end users)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the Changelog with details of my change in the UNRELEASED section if this change will affect end users

@github-actions
Copy link
Copy Markdown

Looks good. All 4 mutations in this change were killed.

class surviving killed
💯uk.nhs.adaptors.gp2gp.gpc.StructuredRecordMappingService 0 4

See https://pitest.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant