Refactor AzureStorageService to inject BlobContainerClient instead of BlobClient

[MartinWheelerMT]

What

• Move SpotBug suppression warning to the exclude file, for consistency when suppressing the warning for thread safe immutable cloud dependencies.
• Refactor AzureStorageService and dependent tests to now inject the container client service, reducing the need to create a new one each time a work function is called against the service.

Why

The adaptor only ever accesses a single blob container with the name as provided in the configuration. At present the adaptor injects a BlobClient and creates a new BlobContainerClient each time an operation is performed against that container. That is inefficient and wasteful of resources.

This fix corrects that by injecting the BlobContainerClient instead.

This also moves the SpotBugs suppression warnings to the SpotBugs Exclusion File to ensure consistency and remove code bloat.

Type of change

Please delete options that are not relevant.

• Internal change (non-breaking change with no effect on the functionality affecting end users)

Checklist:

• I have performed a self-review of my code
• My changes generate no new warnings
• New and existing unit tests pass locally with my changes

[github-actions]

Looks good. All 4 mutations in this change were killed.

class	surviving	killed
💯uk.nhs.adaptors.pss.translator.storage.AzureStorageService	0	3
💯uk.nhs.adaptors.pss.translator.storage.StorageServiceConfig	0	1

See https://pitest.org

• Arcmutate licence valid until 2028-03-02 (yyyy/mm/dd) (non-commercial use only)
• Project uses Spring, but the Arcmutate Spring plugin is not present.

[github-actions]

Images built and published to ECR using a Build Id of PR-1033-7656cfb