Fix: [AEA-6568] - Unable to login with multiple tracker UI tabs open#2092
Open
deanflint-nhs wants to merge 8 commits intomainfrom
Open
Fix: [AEA-6568] - Unable to login with multiple tracker UI tabs open#2092deanflint-nhs wants to merge 8 commits intomainfrom
deanflint-nhs wants to merge 8 commits intomainfrom
Conversation
…logout is already handled
Co-authored-by: Connor Avery <connor.avery2@nhs.net>
Co-authored-by: Connor Avery <connor.avery2@nhs.net>
| }) | ||
| }) | ||
|
|
||
| it("redirects signed-in user from logout to root when logout redirect was already handled in this tab", async () => { |
Contributor
There was a problem hiding this comment.
This test doesn't mock or set the useRef value - I don't believe it's testing the new branch on the if statement for sign-in on another tab
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
[WIP] - Details to be added once fixed