Skip to content

fixing release candidate workflow by adding proxygen TF_VAR #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eddalmond1 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fixing release candidate workflow by adding proxygen TF_VAR #575

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bcd747
fixing release candidate workflow by adding proxygen TF_VAR
eddalmond1 Feb 10, 2026
0432a5b
Merge branch 'main' into bugfix/eja-add-TF_VAR-to-release-candidate-w…
eddalmond1 Feb 11, 2026
0644370
Merge branch 'main' into bugfix/eja-add-TF_VAR-to-release-candidate-w…
eddalmond1 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-candidate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@ jobs:
TF_VAR_SPLUNK_HEC_TOKEN: ${{ secrets.SPLUNK_HEC_TOKEN }}
TF_VAR_SPLUNK_HEC_ENDPOINT: ${{ secrets.SPLUNK_HEC_ENDPOINT }}
TF_VAR_OPERATOR_EMAILS: ${{ vars.SECRET_ROTATION_OPERATOR_EMAILS }}
TF_VAR_PROXYGEN_PRIVATE_KEY_PTL: ${{ secrets.PROXYGEN_PRIVATE_KEY_PTL }}
TF_VAR_PROXYGEN_PRIVATE_KEY_PROD: ${{ secrets.PROXYGEN_PRIVATE_KEY_PROD }}
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TF_VAR_PROXYGEN_PRIVATE_KEY_PTL variable was removed from the deploy-to-test job's env block. However, the Terraform variables.tf (infrastructure/stacks/networking/variables.tf, line 16) declares PROXYGEN_PRIVATE_KEY_PTL as a required variable (no default value), meaning Terraform will require it to be supplied at plan/apply time for all environments, even though the SSM parameter resource only creates it when environment == "dev". Without this variable being set, the Terraform apply for the test environment will fail with an error about a missing required variable.

Every other workflow that runs Terraform apply consistently provides both keys together (e.g., base-deploy.yml lines 206–207, cicd-3-test-deploy.yaml lines 93–94, cicd-2-publish.yaml lines 106–107). The TF_VAR_PROXYGEN_PRIVATE_KEY_PTL should be restored alongside TF_VAR_PROXYGEN_PRIVATE_KEY_PROD in this job's env block.

Suggested change
TF_VAR_PROXYGEN_PRIVATE_KEY_PROD: ${{ secrets.PROXYGEN_PRIVATE_KEY_PROD }}
TF_VAR_PROXYGEN_PRIVATE_KEY_PROD: ${{ secrets.PROXYGEN_PRIVATE_KEY_PROD }}
TF_VAR_PROXYGEN_PRIVATE_KEY_PTL: ${{ secrets.PROXYGEN_PRIVATE_KEY_PTL }}

Copilot uses AI. Check for mistakes.

run: |
Expand Down Expand Up @@ -338,6 +337,7 @@ jobs:
TF_VAR_SPLUNK_HEC_TOKEN: ${{ secrets.SPLUNK_HEC_TOKEN }}
TF_VAR_SPLUNK_HEC_ENDPOINT: ${{ secrets.SPLUNK_HEC_ENDPOINT }}
TF_VAR_OPERATOR_EMAILS: ${{ vars.SECRET_ROTATION_OPERATOR_EMAILS }}
TF_VAR_PROXYGEN_PRIVATE_KEY_PROD: ${{ secrets.PROXYGEN_PRIVATE_KEY_PROD }}
run: |
mkdir -p ./build
echo "🚀 Deploying ${{ needs.validate.outputs.dev_tag }} to PREPROD"
Expand Down
Loading