Skip to content

[GPCAPIM-285] JWT creation#88

Open
Vox-Ben wants to merge 9 commits intomainfrom
feature/GPCAPIM-285_jwt
Open

[GPCAPIM-285] JWT creation#88
Vox-Ben wants to merge 9 commits intomainfrom
feature/GPCAPIM-285_jwt

Conversation

@Vox-Ben
Copy link
Contributor

@Vox-Ben Vox-Ben commented Feb 24, 2026

Description

This adds code for creating a JWT and passing it to the GP provider with the request. Note that at present we aren't sure how some fields will be obtained, so they're hard-coded to placeholder values for the time being.

Context

It is a requirement to pass a JWT to the provider for auditing purposes. This fulfils that requirement.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@Vox-Ben Vox-Ben requested a review from a team as a code owner February 24, 2026 15:19
@github-actions
Copy link

github-actions bot commented Feb 24, 2026

Trivy gate: no Critical/High issues.

Trivy IaC (Terraform) Summary

Severity Count
CRITICAL 0
HIGH 0
MEDIUM 0
LOW 0
UNKNOWN 0
Findings (top 50)
Severity ID Title File

@github-actions
Copy link

github-actions bot commented Feb 24, 2026

Trivy gate: no Critical/High vulnerabilities.

Trivy Image Scan Summary

Image: 900119715266.dkr.ecr.eu-west-2.amazonaws.com/whoami:feature-gpcapim-285-jwt

Severity Count
CRITICAL 0
HIGH 0
MEDIUM 0
LOW 1
UNKNOWN 0
Findings (top 50)
Severity ID Package Installed Fixed Source
LOW CVE-2026-1703 pip 25.3 26.0 Python

Copy link
Contributor

@davidhamill1-nhs davidhamill1-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

A few comments, but mostly superficial or my out-loud thoughts.

@Vox-Ben Vox-Ben force-pushed the feature/GPCAPIM-285_jwt branch from a6c56b3 to ef50081 Compare February 27, 2026 14:44
@Vox-Ben Vox-Ben force-pushed the feature/GPCAPIM-285_jwt branch from ef50081 to c1ef469 Compare March 2, 2026 22:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2026

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

Deployment Complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants