Fixing Validation Issues in BARS#588
Open
KazeemHamzat wants to merge 24 commits into
Open
Conversation
Updating to recent UKCore and NHSDigital Package
Update Options.json
Using NHSDigital 2.5.0
Using 2.11.0
Added UKCore Profiles in rest.resource
Update CodeSystem\rejected-reasons-barrs
Updated CS
Corrected XML version to 1.0
Added description
Added Description
826 | for (let focus of messageDefinition.focus) {
827 | // Having a messageHeader be the focus of a MessageHeader makes no sense - potential loop
> 828 | expect(focus.code !== 'MessageHeader').toBeTruthy()
| ^
829 | expect(focus.code.endsWith('Definition')).toBeFalsy()
830 | }
831 |
Using UKCore Stu 2 balloted
1, BARSMessageHeaderBooking-Request. 2. BARSMessageHeaderServiceRequestRequest 3. BARSMessageHeaderServiceRequestResponse
Update to latest UKCore & NHSDigital
Added "hl7.fhir.uv.xver-r5.r4": "0.1.0",
BARS-EndPoint-Environmenttype-Example
Add Meta.profile
Create ARS-EndPoint-EnvironmenttypewithIdentifiers-Example.
Added Identifiers
KazeemHamzat
requested review from
DaveBarnet,
NaminderSoorma,
cda69,
marcusfearnett-nhsdigital,
omarisgreat and
ryma2fhir
ryma2fhir
previously approved these changes
Apr 28, 2026
ryma2fhir
approved these changes
Apr 29, 2026
Author
|
@omarisgreat here is the BARS PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BARS is currently using older version of UKCore package as dependency which has some invalid assets in it. This is causing issues when BARS package is used as dependency in Frameworks repo.
Issues resolved:
Updated UKCore and NHSDigital packages to recent package
Update BARS CS to conform to the requirements of Profile: https://fhir.nhs.uk/StructureDefinition/NHSDigital-CapabilityStatement
Updated MessageDefinition instances to conform to requirements of IOPS Validation.
826 | for (let focus of messageDefinition.focus) {
827 | // Having a messageHeader be the focus of a MessageHeader makes no sense - potential loop
> 828 | expect(focus.code !== 'MessageHeader').toBeTruthy()
Fixed differential element issues in BARS Profiles
Removed the definition of R5 ExtensionEndpoint_EnvironmentType