Skip to content

Upgrade to 4GB #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KazeemHamzat merged 8 commits into from
Mar 3, 2026
Merged

Upgrade to 4GB #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9b5628b
Upgrade to 4GB
KazeemHamzat Mar 3, 2026
f58fe17
Update to 2gb - 8gb
KazeemHamzat Mar 3, 2026
742b7a4
Testing with 8GB
KazeemHamzat Mar 3, 2026
fa01986
Testing with 12s
KazeemHamzat Mar 3, 2026
5694c88
Update
KazeemHamzat Mar 3, 2026
833e4e2
Retry: This lines address the "$validate-code" read timeoout
KazeemHamzat Mar 3, 2026
29c4ec9
Merge branch 'Testing-with-8GB' of https://github.com/NHSDigital/IOPS…
KazeemHamzat Mar 3, 2026
1cfdd81
Testing with 8GB
KazeemHamzat Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/masterfhirvalidation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@ jobs:

- name: Build FHIR
env:
MAVEN_OPTS: -Xmx2G
MAVEN_OPTS: -Xmx8G
run: cd validation-service-fhir-r4 && mvn clean package

- name: Run FHIR Validator
run: |
nohup java -Xmx2G -jar validation-service-fhir-r4/target/fhir-validator.jar --terminology.url=https://ontology.nhs.uk/production1/fhir --terminology.authorization.tokenUrl=https://ontology.nhs.uk/authorisation/auth/realms/nhs-digital-terminology/protocol/openid-connect/token --terminology.authorization.clientId=${{ secrets.ONTO_CLIENT_ID }} --terminology.authorization.clientSecret=${{ secrets.ONTO_CLIENT_SECRET }} --aws.validationSupport=false --aws.queueEnabled=false &
nohup java Xms2G-Xmx8G -jar validation-service-fhir-r4/target/fhir-validator.jar --terminology.url=https://ontology.nhs.uk/production1/fhir --terminology.authorization.tokenUrl=https://ontology.nhs.uk/authorisation/auth/realms/nhs-digital-terminology/protocol/openid-connect/token --terminology.authorization.clientId=${{ secrets.ONTO_CLIENT_ID }} --terminology.authorization.clientSecret=${{ secrets.ONTO_CLIENT_SECRET }} --aws.validationSupport=false --aws.queueEnabled=false &
# Wait for it to become ready, try 30 times, with 10 seconds between
for i in {1..60}; do
if curl -sSf http://localhost:9001/metadata > /dev/null || \
Expand Down
8 changes: 6 additions & 2 deletions src/validator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,16 @@ import {AxiosInstance} from "axios";
import fs from "fs";


// Retry: This lines address the "$validate-code" read timeoout (e.g., when the terminology endpoint is slow)
jest.retryTimes(2, { logErrorsBeforeRetry: true });

const args = require('minimist')(process.argv.slice(2))
// Retry flaky specs (e.g., when the terminology endpoint is slow)
jest.retryTimes(2, { logErrorsBeforeRetry: true });

const args = require('minimist')(process.argv.slice(2))

let terminology = true;
jest.setTimeout(40*1000)
jest.setTimeout(120_000)

let gitHubSummary = '### :fire_engine: Logs '+NEW_LINE;

Expand Down