feat: Tweak classpath handling slightly to not drop one level in the class loader hierarchy#5
Open
feat: Tweak classpath handling slightly to not drop one level in the class loader hierarchy#5
Conversation
…class loader hierarchy. Should allow using classpath entries added via the launch script. Also updates the bundled jar to the latest code.
soloturn
approved these changes
Oct 27, 2023
soloturn
left a comment
soloturn
left a comment
There was a problem hiding this comment.
looks ok. was there a case where you noticed a problem?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should allow using classpath entries added via the launch script. Also updates the bundled jar to the latest code.
For the utility setup within Terasology this lets execution access bundled Groovy classes as actual classes, rather than the awkward approach of loading them first as files, then dynamically instantiating them.