Repository navigation
Conversation
🦋 Changeset detectedLatest commit: e7a8dc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
💡 Codex ReviewWhen a custom registry supplies only AGENTS.md reference: AGENTS.md:L98-L100 Migration candidates are only delivered through this live global WebSocket event. The startup scheduler begins refreshing immediately after the server starts listening, global targets do not replay the AGENTS.md reference: AGENTS.md:L110-L112 https://github.com/MoonshotAI/kimi-code/blob/e7a8dc7097e91b75829b4934ee61c992d1601049/apps/kimi-code/dist-web/assets/index-BUlO2hUi.js#L177 This reducer treats every refresh report as a complete migration snapshot, but AGENTS.md reference: AGENTS.md:L18-L18 kimi-code/packages/klient/src/contract/global/events.ts Lines 91 to 104 in e7a8dc7 Although this schema now preserves AGENTS.md reference: packages/klient/AGENTS.md:L14-L17 kimi-code/packages/oauth/src/refreshProviderModels.ts Lines 780 to 789 in e7a8dc7 Candidates are appended before the provider's credential and application checks run. If an existing registry provider has conflicting credentials or an AGENTS.md reference: AGENTS.md:L98-L100 https://github.com/MoonshotAI/kimi-code/blob/e7a8dc7097e91b75829b4934ee61c992d1601049/apps/kimi-code/dist-web/assets/index-BUlO2hUi.js#L138 The bundle maps AGENTS.md reference: AGENTS.md:L18-L18 https://github.com/MoonshotAI/kimi-code/blob/e7a8dc7097e91b75829b4934ee61c992d1601049/apps/kimi-code/dist-web/assets/index-BUlO2hUi.js#L177 Completing a migration records a persistent AGENTS.md reference: AGENTS.md:L18-L18 kimi-code/packages/oauth/src/custom-registry.ts Lines 243 to 244 in e7a8dc7 Before this change an unknown AGENTS.md reference: AGENTS.md:L98-L100 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Requirement or Bug
Support Codex-style
upgrademetadata in custom registries, so Web and desktop clients can guide users through model migration.Bug Reproduction Steps
N/A
Root Cause
N/A
Code Changes
upgradein custom registries; reject malformed timestamps.event.model_catalog.changedwith optionalmigrations.Behavior Changes and Affected Users
| Behavior | Before | After | Who relies on the old behavior | Escape hatch |
| Custom registry upgrade metadata | Ignored by the refresh pipeline | Returned as migration candidates and broadcast to Web/Desktop clients | Custom-registry providers and Web/Desktop users | N/A |
| Default model selection | Unchanged by refresh | Still unchanged; users opt into migration in model settings | All current default-model users | No automatic migration required |
| Refresh event broadcast | Sent only when aliases changed | Also sent when upgrade metadata exists | Existing refresh-event consumers | Additive optional field; existing payload shapes are unchanged |
| Invalid upgrade data | Accepted and skipped silently | Rejected with an explicit refresh error | Registry authors | Fix the invalid upgrade metadata |
Checklist
gen-changesets.gen-docs.