Skip to content

fix(apps/kimi-code): allow deselecting Other option in multi-select question dialog - #2810

Merged
liruifengv merged 1 commit into
MoonshotAI:mainfrom
huangzheng2016:fix/multi-select-other-deselect
Aug 11, 2026
Merged

fix(apps/kimi-code): allow deselecting Other option in multi-select question dialog#2810
liruifengv merged 1 commit into
MoonshotAI:mainfrom
huangzheng2016:fix/multi-select-other-deselect

Conversation

@huangzheng2016

Copy link
Copy Markdown
Contributor

Related Issue

N/A

Problem

In the TUI's AskUserQuestion multi-select dialog, selecting the synthetic "Other" option and committing a custom value permanently adds it to the selection set. There was no way to deselect "Other" afterwards, because pressing Enter/Space on "Other" always re-entered edit mode instead of toggling its selected state.

What changed

  • In apps/kimi-code/src/tui/components/dialogs/question-dialog.ts, activateQuestionOption now checks whether "Other" is already selected in multi-select mode. If so, it removes the option from multiSelections and updates the answer, effectively toggling it off. If not selected, it still enters the inline Other editor as before.
  • Added a component test multi-select Other can be toggled off after it is committed covering the toggle-off behavior.
  • Added a patch changeset for @moonshot-ai/kimi-code.

Checklist

  • I have read the CONTRIBUTING document.
  • I have explained the problem above.
  • I have added tests that prove my feature works.
  • Ran gen-changesets skill, or this PR needs no changeset.

@changeset-bot

changeset-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: aa56edb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@moonshot-ai/kimi-code Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Aug 11, 2026

Copy link
Copy Markdown
pnpm dlx https://pkg.pr.new/@moonshot-ai/kimi-code@aa56edb
npx https://pkg.pr.new/@moonshot-ai/kimi-code@aa56edb

commit: aa56edb

@liruifengv liruifengv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@liruifengv
liruifengv merged commit 64abebc into MoonshotAI:main Aug 11, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants