Repository navigation
Use RPC budget for Codex turn start - #596
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A live second Turn failed because turn/start imposed its own 10-second acknowledgement deadline, even though the configured RPC response budget was still available. Use that existing RPC budget and the caller’s cancellation context for turn/start. Native result binding, uncertain Turn ownership, settlement, cleanup and the prohibition on input replay stay intact.
Validation: the same 11-second acknowledgement fails against the old implementation and succeeds after the change. Configured short-budget and parent-cancellation tests verify the exact owned Turn, one input submission, failed settlement and process cleanup; these and existing ordering/cancellation/ownership regressions pass race ×50. Full Codex package, vet/build, Darwin/Windows builds and hygiene checks pass. The live cause of the delayed acknowledgement remains unmeasured; this PR does not claim a completed native qualification.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.