Repository navigation
Allow native preparation in Files acceptance - #595
Merged
SaladDay merged 1 commit intoOct 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Files native acceptance client inherited the raw HTTP client’s 30-second timeout, which ends the first input before observed native preparation can finish. Give the pinned SDK the same 240-second budget already used by native acceptance, while retaining 30-second raw HTTP reads, strict validation, zero retries and every Files assertion.
Validation: 24 existing runner/schema checks and names/docs/CI hygiene passed. Pinned-SDK MockTransport checks exercised both clients’ actual events.create requests: baseline read timeout 30 seconds, updated timeout 240 seconds, raw GET still 30 seconds, and one request on 503 with retries disabled. This test-only change does not itself establish a live Files pass.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.