Repository navigation
Use the Codex RPC budget for MCP checks - #593
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A valid native
config/readresponse arriving after five seconds was rejected by the MCP preflight's independent deadline. Use the existing RPC request budget and parent context instead. Exact MCP configuration matching, secret-safe errors and verification before starting or resuming a thread remain unchanged; no settings, retries or other timeout changes are added.Validation: the existing real preparation helper returns valid configuration after six seconds. This regression fails at 5.01 seconds with the original production file supplied through a Go overlay and passes with the change. A short configured RPC budget and explicit parent cancellation still return the fixed redacted error. Existing new/resumed-thread and ambient/bearer rejection checks pass. The complete Codex package, vet, Darwin/Windows builds, hygiene and post-commit MCP checks pass; the delayed case passes under race, and the short timeout/cancellation cases pass 50 race repetitions.
No deployment or model execution was performed in this lane. Fresh remote acceptance remains required.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.