Port Meteor Client to Minecraft 26.1.1#6285
Port Meteor Client to Minecraft 26.1.1#6285Mason-Mohon wants to merge 1 commit intoMeteorDevelopment:masterfrom
Conversation
…ring. Update build/dependency versions and migration fixes for 26.1.1 API changes, and move widget rendering to GameRenderer's render stage so Meteor GUI is visible and interactive again. Made-with: Cursor
|
There's no way I'm merging a PR that is a paste of the existing one, especially when it was fed into an LLM that has no knowledge nor can reason about the logic and changes Mojang introduced. |
|
Apologies @Big-Iron-Cheems, I did not mean any disrespect by it. Just had Cursor work on this last night until I verified that it was working, didn't realize it was cloning an existing PR. Was only trying to be helpful! |
|
Furthermore, to clarify, this was not a copy-paste. Just looked at your PR and if the PR body text is to be believed it doesn't build yet? This one does, I was using it last night. Please correct me if I am missing something or if the documentation on your PR isn't up to date. |
|
Last thing, I ensured my agents had knowledge of Mojang's changes by putting the games unobfuscated source in the same workspace. I work with agents a lot and know how to give them proper context. I wouldn't have made a PR if I hadn't verified that the changes worked in-game. Genuinely was trying to be helpful |
|
There are several issues and wrong assumptions LLMs make about this all the times, including in this PR. Generally, we are not accepting LLM code unless:
|
|
Completely understood and I apologize for stepping on any toes. My main purpose was to have it running for myself, which is what I accomplished. To clarify; I'm not just saying my version builds. It loads in game, I had many bugs at that point especially with UI, got those fixed as well. My hope was that it would at least be helpful for me to share since it's fully operational (in multiplayer too!) so I hoped it would be useful in some way. But in retrospect I certainly could have gone about it better and branched off from your PR, submitted the smaller changes for your review, and that was an oversight on my part entirely. Thanks for the work you do on Meteor, it is great. |
Summary
Path Manager: Baritone) when paired with the local 26.1.1 Baritone buildTest plan
./gradlew runClient --console=plainRight Shift), verify menu is visible and interactiveMade with Cursor