Skip to content

Port Meteor Client to Minecraft 26.1.1#6285

Closed
Mason-Mohon wants to merge 1 commit intoMeteorDevelopment:masterfrom
Mason-Mohon:mc-26.1.1-port
Closed

Port Meteor Client to Minecraft 26.1.1#6285
Mason-Mohon wants to merge 1 commit intoMeteorDevelopment:masterfrom
Mason-Mohon:mc-26.1.1-port

Conversation

@Mason-Mohon
Copy link
Copy Markdown

Summary

  • migrate Meteor Client build and mappings to run on Minecraft 26.1.1 and Fabric Loader 0.18.6
  • apply runtime/API compatibility fixes discovered during iterative launch validation, including WidgetScreen rendering routed via GameRenderer render stage
  • verify Baritone integration path resolves at runtime (Path Manager: Baritone) when paired with the local 26.1.1 Baritone build

Test plan

  • ./gradlew runClient --console=plain
  • open world, open Meteor GUI (Right Shift), verify menu is visible and interactive
  • verify vanilla HUD/hotbar remains visible with Meteor GUI fix
  • verify Meteor chat feedback and module interactions still respond

Made with Cursor

…ring.

Update build/dependency versions and migration fixes for 26.1.1 API changes, and move widget rendering to GameRenderer's render stage so Meteor GUI is visible and interactive again.

Made-with: Cursor
@Big-Iron-Cheems
Copy link
Copy Markdown
Collaborator

There's no way I'm merging a PR that is a paste of the existing one, especially when it was fed into an LLM that has no knowledge nor can reason about the logic and changes Mojang introduced.
It's in the exact same state as our PR as well, there's nothing here that we hadn't figured out already.
This is disrespectful to our work as a whole.

@Mason-Mohon Mason-Mohon deleted the mc-26.1.1-port branch April 5, 2026 10:57
@Mason-Mohon
Copy link
Copy Markdown
Author

Apologies @Big-Iron-Cheems, I did not mean any disrespect by it. Just had Cursor work on this last night until I verified that it was working, didn't realize it was cloning an existing PR. Was only trying to be helpful!

@Mason-Mohon
Copy link
Copy Markdown
Author

Furthermore, to clarify, this was not a copy-paste. Just looked at your PR and if the PR body text is to be believed it doesn't build yet? This one does, I was using it last night. Please correct me if I am missing something or if the documentation on your PR isn't up to date.

@Mason-Mohon
Copy link
Copy Markdown
Author

Last thing, I ensured my agents had knowledge of Mojang's changes by putting the games unobfuscated source in the same workspace. I work with agents a lot and know how to give them proper context. I wouldn't have made a PR if I hadn't verified that the changes worked in-game. Genuinely was trying to be helpful

@Big-Iron-Cheems
Copy link
Copy Markdown
Collaborator

Big-Iron-Cheems commented Apr 5, 2026

There are several issues and wrong assumptions LLMs make about this all the times, including in this PR.
(I am not enumerating all of them, it's a sea of mistakes).
I refuse to "feed the machine" when it has no idea of what is right or wrong, even more so when the person operating it is just as clueless about anything it did.
As a final addition, just because it builds doesn't mean it's right, there's plenty of bugs that one will experience only after the game loads properly.

Generally, we are not accepting LLM code unless:

  • we are familiar with the contributor and know his level of acquaintance with all the required domain knowledge;
  • the amount of code to be reviewed is minimal, we cannot trust massive changes such as an entire game update.

@Mason-Mohon
Copy link
Copy Markdown
Author

Mason-Mohon commented Apr 5, 2026

Completely understood and I apologize for stepping on any toes. My main purpose was to have it running for myself, which is what I accomplished. To clarify; I'm not just saying my version builds. It loads in game, I had many bugs at that point especially with UI, got those fixed as well. My hope was that it would at least be helpful for me to share since it's fully operational (in multiplayer too!) so I hoped it would be useful in some way. But in retrospect I certainly could have gone about it better and branched off from your PR, submitted the smaller changes for your review, and that was an oversight on my part entirely. Thanks for the work you do on Meteor, it is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants