Skip to content

Description #2943

Open
lannathompson65-arch wants to merge 13 commits into
MetaMask:mainfrom
lannathompson65-arch:main
Open

Description #2943
lannathompson65-arch wants to merge 13 commits into
MetaMask:mainfrom
lannathompson65-arch:main

Conversation

@lannathompson65-arch

@lannathompson65-arch lannathompson65-arch commented Jun 3, 2026

Copy link
Copy Markdown

Description

Issue(s) fixed

Fixes #

Preview

Checklist

  • If this PR updates or adds documentation content that changes or adds technical meaning, it has received an approval from an engineer or DevRel from the relevant team.
  • If this PR updates or adds documentation content, it has received an approval from a technical writer.

External contributor checklist

  • I've read the contribution guidelines.
  • I've created a new issue (or assigned myself to an existing issue) describing what this PR addresses.

Note

High Risk
New workflows on main/PRs can fail repeatedly (Deno, Gradle/zScan, incomplete SonarCloud/Codacy config) and the unrelated root index.html is confusing for a docs repo; only the devDependency bump is clearly intentional.

Overview
This PR adds four new GitHub Actions workflows on main push/PR (and Codacy on a weekly cron): Codacy (SARIF upload, needs CODACY_PROJECT_TOKEN), SonarCloud (needs SONAR_TOKEN and still has empty sonar.projectKey / sonar.organization), Deno (deno lint / deno test -A), and Zimperium zScan (./gradlew build plus mobile APK placeholders and ZSCAN_CLIENT_SECRET). Those jobs are largely stock templates and are unlikely to match this Docusaurus docs repo without extra setup, so they may fail or add noise on every run.

It also adds a root index.html to-do demo (references styles.css / script.js not in the diff), a generic SECURITY.md policy template, and bumps @typescript-eslint/parser from ^8.46.2 to ^8.58.2 in package.json with a matching package-lock.json refresh.

Reviewed by Cursor Bugbot for commit 0f5c3d8. Bugbot is set up for automated code reviews on this repo. Configure here.

lannathompson65-arch and others added 13 commits April 14, 2026 14:37
Added a security policy document outlining supported versions and vulnerability reporting.
This workflow installs Deno and runs linting and tests on push and pull request events.
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 8.46.2 to 8.58.2.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.58.2/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-version: 8.58.2
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…#3)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 8.46.2 to 8.58.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@​typescript-eslint/parser</code>'s releases</a>.</em></p>
<blockquote>
<h2>v8.58.2</h2>
<h2>8.58.2 (2026-04-13)</h2>
<h3>🩹 Fixes</h3>
<ul>
<li>remove tsbuildinfo cache file from published packages (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12187">#12187</a>)</li>
<li><strong>eslint-plugin:</strong> [no-unnecessary-condition] use assignability checks in checkTypePredicates (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12147">#12147</a>)</li>
</ul>
<h3>❤️ Thank You</h3>
<ul>
<li>Abhijeet Singh <a href="https://github.com/cseas"><code>@​cseas</code></a></li>
<li>송재욱</li>
</ul>
<p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.58.2">GitHub Releases</a> for more information.</p>
<p>You can read about our <a href="https://typescript-eslint.io/users/versioning">versioning strategy</a> and <a href="https://typescript-eslint.io/users/releases">releases</a> on our website.</p>
<h2>v8.58.1</h2>
<h2>8.58.1 (2026-04-08)</h2>
<h3>🩹 Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> [no-unused-vars] fix false negative for type predicate parameter (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12004">#12004</a>)</li>
</ul>
<h3>❤️ Thank You</h3>
<ul>
<li>MinJae <a href="https://github.com/Ju-MINJAE"><code>@​Ju-MINJAE</code></a></li>
</ul>
<p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.58.1">GitHub Releases</a> for more information.</p>
<p>You can read about our <a href="https://typescript-eslint.io/users/versioning">versioning strategy</a> and <a href="https://typescript-eslint.io/users/releases">releases</a> on our website.</p>
<h2>v8.58.0</h2>
<h2>8.58.0 (2026-03-30)</h2>
<h3>🚀 Features</h3>
<ul>
<li>support TypeScript 6 (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12124">#12124</a>)</li>
</ul>
<h3>🩹 Fixes</h3>
<ul>
<li><strong>eslint-plugin:</strong> crash in <code>no-unnecessary-type-arguments</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12163">#12163</a>)</li>
<li><strong>eslint-plugin:</strong> [no-extraneous-class] handle index signatures (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12142">#12142</a>)</li>
<li><strong>eslint-plugin:</strong> [prefer-regexp-exec] avoid fixing unknown RegExp flags (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12161">#12161</a>)</li>
</ul>
<h3>❤️ Thank You</h3>
<ul>
<li>ej shafran <a href="https://github.com/ej-shafran"><code>@​ej-shafran</code></a></li>
<li>Evyatar Daud <a href="https://github.com/StyleShit"><code>@​StyleShit</code></a></li>
<li>GG ZIBLAKING</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md"><code>@​typescript-eslint/parser</code>'s changelog</a>.</em></p>
<blockquote>
<h2>8.58.2 (2026-04-13)</h2>
<h3>🩹 Fixes</h3>
<ul>
<li>remove tsbuildinfo cache file from published packages (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12187">#12187</a>)</li>
</ul>
<h3>❤️ Thank You</h3>
<ul>
<li>Abhijeet Singh <a href="https://github.com/cseas"><code>@​cseas</code></a></li>
</ul>
<p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.58.2">GitHub Releases</a> for more information.</p>
<p>You can read about our <a href="https://typescript-eslint.io/users/versioning">versioning strategy</a> and <a href="https://typescript-eslint.io/users/releases">releases</a> on our website.</p>
<h2>8.58.1 (2026-04-08)</h2>
<p>This was a version bump only for parser to align it with other projects, there were no code changes.</p>
<p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.58.1">GitHub Releases</a> for more information.</p>
<p>You can read about our <a href="https://typescript-eslint.io/users/versioning">versioning strategy</a> and <a href="https://typescript-eslint.io/users/releases">releases</a> on our website.</p>
<h2>8.58.0 (2026-03-30)</h2>
<h3>🚀 Features</h3>
<ul>
<li>support TypeScript 6 (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12124">#12124</a>)</li>
</ul>
<h3>❤️ Thank You</h3>
<ul>
<li>Evyatar Daud <a href="https://github.com/StyleShit"><code>@​StyleShit</code></a></li>
</ul>
<p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.58.0">GitHub Releases</a> for more information.</p>
<p>You can read about our <a href="https://typescript-eslint.io/users/versioning">versioning strategy</a> and <a href="https://typescript-eslint.io/users/releases">releases</a> on our website.</p>
<h2>8.57.2 (2026-03-23)</h2>
<p>This was a version bump only for parser to align it with other projects, there were no code changes.</p>
<p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.57.2">GitHub Releases</a> for more information.</p>
<p>You can read about our <a href="https://typescript-eslint.io/users/versioning">versioning strategy</a> and <a href="https://typescript-eslint.io/users/releases">releases</a> on our website.</p>
<h2>8.57.1 (2026-03-16)</h2>
<p>This was a version bump only for parser to align it with other projects, there were no code changes.</p>
<p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.57.1">GitHub Releases</a> for more information.</p>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/90c2803a4c250e0343598d41e973f95e743bf4ce"><code>90c2803</code></a> chore(release): publish 8.58.2</li>
<li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/be6b49a02d68db9bdc8985e7e9e1598700fda2fa"><code>be6b49a</code></a> fix: remove tsbuildinfo cache file from published packages (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser/issues/12187">#12187</a>)</li>
<li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/5311ed312eadf4e238324f2726ae0b1f3f2206e6"><code>5311ed3</code></a> chore(release): publish 8.58.1</li>
<li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/493341709fe7d1d6433332b7bd2724e3332c7cdf"><code>4933417</code></a> chore(release): publish 8.58.0</li>
<li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/8cde2d06fb9bc591a4c93452509ddbd600c76a35"><code>8cde2d0</code></a> feat: support TypeScript 6 (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser/issues/12124">#12124</a>)</li>
<li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/be4d54d26e695cc93605ffcca67dd75848e95c6f"><code>be4d54d</code></a> chore(release): publish 8.57.2</li>
<li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/c7c38aa252d7bf6708a225aebedc57686ac33dcd"><code>c7c38aa</code></a> chore(release): publish 8.57.1</li>
<li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/2c6aeeec238dfea860b9f3c146a55f8f49f15cf5"><code>2c6aeee</code></a> chore(release): publish 8.57.0</li>
<li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/f696dadfc37078efe4119ad2ab0609cde3e42766"><code>f696dad</code></a> chore: use pnpm catalog (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser/issues/12047">#12047</a>)</li>
<li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/a09921e2de2e8790e6a803016b825815ca9409d8"><code>a09921e</code></a> chore: update vitest to 4.x (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser/issues/12071">#12071</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v8.58.2/packages/parser">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@typescript-eslint/parser&package-manager=npm_and_yarn&previous-version=8.46.2&new-version=8.58.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
# Description

<!-- Describe the changes made in your pull request (PR). -->

## Issue(s) fixed

<!-- Include the issue number that this PR fixes. -->

Fixes #

## Preview

<!-- Provide a PR preview link to the page(s) changed. -->

## Checklist

<!-- Complete the following checklist before merging your PR. -->

- [ ] If this PR updates or adds documentation content that changes or adds technical meaning, it has received an approval from an engineer or DevRel from the relevant team.
- [ ] If this PR updates or adds documentation content, it has received an approval from a technical writer.

## External contributor checklist

<!-- If you are an external contributor (outside of the MetaMask organization), complete the following checklist. -->

- [ ] I've read the [contribution guidelines](https://github.com/MetaMask/metamask-docs/blob/main/CONTRIBUTING.md).
- [ ] I've created a new issue (or assigned myself to an existing issue) describing what this PR addresses.
@lannathompson65-arch lannathompson65-arch requested review from a team as code owners June 3, 2026 01:47
@vercel

vercel Bot commented Jun 3, 2026

Copy link
Copy Markdown

@lannathompson65-arch is attempting to deploy a commit to the Consensys Team on Vercel.

A member of the Team first needs to authorize it.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​typescript-eslint/​parser@​8.46.2 ⏵ 8.58.2100 +110071 +198100

View full report

@socket-security

Copy link
Copy Markdown

Warning

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Action Severity Alert  (click "▶" to expand/collapse)
Warn Medium
Medium CVE: npm brace-expansion: Large numeric range defeats documented `max` DoS protection

CVE: GHSA-jxxr-4gwj-5jf2 brace-expansion: Large numeric range defeats documented max DoS protection (MODERATE)

Affected versions: >= 5.0.0 < 5.0.6

Patched version: 5.0.6

From: package-lock.jsonnpm/@typescript-eslint/parser@8.58.2npm/brace-expansion@5.0.5

ℹ Read more on: This package | This alert | What is a medium CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known medium severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/brace-expansion@5.0.5. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 5 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0f5c3d8. Configure here.

uses: actions/checkout@v4

- name: Execute gradle build
run: ./gradlew build # Change this to build your mobile application

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zscan workflow runs missing gradlew

High Severity

The zScan job runs ./gradlew build, but this repository has no Gradle wrapper or Android project. The step exits immediately on push and pull requests to main, so the workflow never reaches the scan or SARIF upload.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0f5c3d8. Configure here.

# Adds more detail to both client and server-side analysis logs, activating DEBUG mode for the scanner, and adding client-side environment variables and system properties to the server-side log of analysis report processing.
#-Dsonar.verbose= # optional, default is false
# When you need the analysis to take place in a directory other than the one from which it was launched, default is .
projectBaseDir: .

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarCloud step skips checkout

High Severity

The SonarCloud job has only the SonarSource/sonarcloud-github-action step and never checks out the repository. The scanner runs without project sources, so analysis on main and pull requests cannot produce meaningful results.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0f5c3d8. Configure here.

# Unique keys of your project and organization. You can find them in SonarCloud > Information (bottom-left menu)
# mandatory
-Dsonar.projectKey=
-Dsonar.organization=

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sonar keys left empty

Medium Severity

-Dsonar.projectKey= and -Dsonar.organization= are committed as empty strings. SonarCloud requires both values from the project settings, so the scanner rejects the run even when SONAR_TOKEN is set.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0f5c3d8. Configure here.

Comment thread index.html
<input type="text" id="new-task" placeholder="Add a new task...">
<button id="add-task">Add Task</button>
<ul id="task-list"></ul>
<script src="script.js"></script>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root HTML missing assets

Medium Severity

The new root index.html links to styles.css and script.js, but neither file exists in the repository. Opening or serving that page leaves the to-do UI unstyled and without behavior.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0f5c3d8. Configure here.

run: deno lint

- name: Run tests
run: deno test -A

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deno CI on Node docs

Medium Severity

The Deno workflow runs deno lint and deno test -A on every main push and PR, but the repo has no deno.json and is built with npm/Docusaurus. Deno lint applies its own rules across the tree and is likely to fail or conflict with existing ESLint CI.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0f5c3d8. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant