Description #2943
Conversation
Added a security policy document outlining supported versions and vulnerability reporting.
This workflow installs Deno and runs linting and tests on push and pull request events.
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 8.46.2 to 8.58.2. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.58.2/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-version: 8.58.2 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…#3) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 8.46.2 to 8.58.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/parser</code>'s releases</a>.</em></p> <blockquote> <h2>v8.58.2</h2> <h2>8.58.2 (2026-04-13)</h2> <h3>🩹 Fixes</h3> <ul> <li>remove tsbuildinfo cache file from published packages (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12187">#12187</a>)</li> <li><strong>eslint-plugin:</strong> [no-unnecessary-condition] use assignability checks in checkTypePredicates (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12147">#12147</a>)</li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Abhijeet Singh <a href="https://github.com/cseas"><code>@cseas</code></a></li> <li>송재욱</li> </ul> <p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.58.2">GitHub Releases</a> for more information.</p> <p>You can read about our <a href="https://typescript-eslint.io/users/versioning">versioning strategy</a> and <a href="https://typescript-eslint.io/users/releases">releases</a> on our website.</p> <h2>v8.58.1</h2> <h2>8.58.1 (2026-04-08)</h2> <h3>🩹 Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [no-unused-vars] fix false negative for type predicate parameter (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12004">#12004</a>)</li> </ul> <h3>❤️ Thank You</h3> <ul> <li>MinJae <a href="https://github.com/Ju-MINJAE"><code>@Ju-MINJAE</code></a></li> </ul> <p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.58.1">GitHub Releases</a> for more information.</p> <p>You can read about our <a href="https://typescript-eslint.io/users/versioning">versioning strategy</a> and <a href="https://typescript-eslint.io/users/releases">releases</a> on our website.</p> <h2>v8.58.0</h2> <h2>8.58.0 (2026-03-30)</h2> <h3>🚀 Features</h3> <ul> <li>support TypeScript 6 (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12124">#12124</a>)</li> </ul> <h3>🩹 Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> crash in <code>no-unnecessary-type-arguments</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12163">#12163</a>)</li> <li><strong>eslint-plugin:</strong> [no-extraneous-class] handle index signatures (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12142">#12142</a>)</li> <li><strong>eslint-plugin:</strong> [prefer-regexp-exec] avoid fixing unknown RegExp flags (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12161">#12161</a>)</li> </ul> <h3>❤️ Thank You</h3> <ul> <li>ej shafran <a href="https://github.com/ej-shafran"><code>@ej-shafran</code></a></li> <li>Evyatar Daud <a href="https://github.com/StyleShit"><code>@StyleShit</code></a></li> <li>GG ZIBLAKING</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md"><code>@typescript-eslint/parser</code>'s changelog</a>.</em></p> <blockquote> <h2>8.58.2 (2026-04-13)</h2> <h3>🩹 Fixes</h3> <ul> <li>remove tsbuildinfo cache file from published packages (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12187">#12187</a>)</li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Abhijeet Singh <a href="https://github.com/cseas"><code>@cseas</code></a></li> </ul> <p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.58.2">GitHub Releases</a> for more information.</p> <p>You can read about our <a href="https://typescript-eslint.io/users/versioning">versioning strategy</a> and <a href="https://typescript-eslint.io/users/releases">releases</a> on our website.</p> <h2>8.58.1 (2026-04-08)</h2> <p>This was a version bump only for parser to align it with other projects, there were no code changes.</p> <p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.58.1">GitHub Releases</a> for more information.</p> <p>You can read about our <a href="https://typescript-eslint.io/users/versioning">versioning strategy</a> and <a href="https://typescript-eslint.io/users/releases">releases</a> on our website.</p> <h2>8.58.0 (2026-03-30)</h2> <h3>🚀 Features</h3> <ul> <li>support TypeScript 6 (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/12124">#12124</a>)</li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Evyatar Daud <a href="https://github.com/StyleShit"><code>@StyleShit</code></a></li> </ul> <p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.58.0">GitHub Releases</a> for more information.</p> <p>You can read about our <a href="https://typescript-eslint.io/users/versioning">versioning strategy</a> and <a href="https://typescript-eslint.io/users/releases">releases</a> on our website.</p> <h2>8.57.2 (2026-03-23)</h2> <p>This was a version bump only for parser to align it with other projects, there were no code changes.</p> <p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.57.2">GitHub Releases</a> for more information.</p> <p>You can read about our <a href="https://typescript-eslint.io/users/versioning">versioning strategy</a> and <a href="https://typescript-eslint.io/users/releases">releases</a> on our website.</p> <h2>8.57.1 (2026-03-16)</h2> <p>This was a version bump only for parser to align it with other projects, there were no code changes.</p> <p>See <a href="https://github.com/typescript-eslint/typescript-eslint/releases/tag/v8.57.1">GitHub Releases</a> for more information.</p> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/90c2803a4c250e0343598d41e973f95e743bf4ce"><code>90c2803</code></a> chore(release): publish 8.58.2</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/be6b49a02d68db9bdc8985e7e9e1598700fda2fa"><code>be6b49a</code></a> fix: remove tsbuildinfo cache file from published packages (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser/issues/12187">#12187</a>)</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/5311ed312eadf4e238324f2726ae0b1f3f2206e6"><code>5311ed3</code></a> chore(release): publish 8.58.1</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/493341709fe7d1d6433332b7bd2724e3332c7cdf"><code>4933417</code></a> chore(release): publish 8.58.0</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/8cde2d06fb9bc591a4c93452509ddbd600c76a35"><code>8cde2d0</code></a> feat: support TypeScript 6 (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser/issues/12124">#12124</a>)</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/be4d54d26e695cc93605ffcca67dd75848e95c6f"><code>be4d54d</code></a> chore(release): publish 8.57.2</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/c7c38aa252d7bf6708a225aebedc57686ac33dcd"><code>c7c38aa</code></a> chore(release): publish 8.57.1</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/2c6aeeec238dfea860b9f3c146a55f8f49f15cf5"><code>2c6aeee</code></a> chore(release): publish 8.57.0</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/f696dadfc37078efe4119ad2ab0609cde3e42766"><code>f696dad</code></a> chore: use pnpm catalog (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser/issues/12047">#12047</a>)</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/a09921e2de2e8790e6a803016b825815ca9409d8"><code>a09921e</code></a> chore: update vitest to 4.x (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser/issues/12071">#12071</a>)</li> <li>Additional commits viewable in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v8.58.2/packages/parser">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
# Description <!-- Describe the changes made in your pull request (PR). --> ## Issue(s) fixed <!-- Include the issue number that this PR fixes. --> Fixes # ## Preview <!-- Provide a PR preview link to the page(s) changed. --> ## Checklist <!-- Complete the following checklist before merging your PR. --> - [ ] If this PR updates or adds documentation content that changes or adds technical meaning, it has received an approval from an engineer or DevRel from the relevant team. - [ ] If this PR updates or adds documentation content, it has received an approval from a technical writer. ## External contributor checklist <!-- If you are an external contributor (outside of the MetaMask organization), complete the following checklist. --> - [ ] I've read the [contribution guidelines](https://github.com/MetaMask/metamask-docs/blob/main/CONTRIBUTING.md). - [ ] I've created a new issue (or assigned myself to an existing issue) describing what this PR addresses.
|
@lannathompson65-arch is attempting to deploy a commit to the Consensys Team on Vercel. A member of the Team first needs to authorize it. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning MetaMask internal reviewing guidelines:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 5 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0f5c3d8. Configure here.
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Execute gradle build | ||
| run: ./gradlew build # Change this to build your mobile application |
There was a problem hiding this comment.
Zscan workflow runs missing gradlew
High Severity
The zScan job runs ./gradlew build, but this repository has no Gradle wrapper or Android project. The step exits immediately on push and pull requests to main, so the workflow never reaches the scan or SARIF upload.
Reviewed by Cursor Bugbot for commit 0f5c3d8. Configure here.
| # Adds more detail to both client and server-side analysis logs, activating DEBUG mode for the scanner, and adding client-side environment variables and system properties to the server-side log of analysis report processing. | ||
| #-Dsonar.verbose= # optional, default is false | ||
| # When you need the analysis to take place in a directory other than the one from which it was launched, default is . | ||
| projectBaseDir: . |
There was a problem hiding this comment.
SonarCloud step skips checkout
High Severity
The SonarCloud job has only the SonarSource/sonarcloud-github-action step and never checks out the repository. The scanner runs without project sources, so analysis on main and pull requests cannot produce meaningful results.
Reviewed by Cursor Bugbot for commit 0f5c3d8. Configure here.
| # Unique keys of your project and organization. You can find them in SonarCloud > Information (bottom-left menu) | ||
| # mandatory | ||
| -Dsonar.projectKey= | ||
| -Dsonar.organization= |
There was a problem hiding this comment.
Sonar keys left empty
Medium Severity
-Dsonar.projectKey= and -Dsonar.organization= are committed as empty strings. SonarCloud requires both values from the project settings, so the scanner rejects the run even when SONAR_TOKEN is set.
Reviewed by Cursor Bugbot for commit 0f5c3d8. Configure here.
| <input type="text" id="new-task" placeholder="Add a new task..."> | ||
| <button id="add-task">Add Task</button> | ||
| <ul id="task-list"></ul> | ||
| <script src="script.js"></script> |
There was a problem hiding this comment.
Root HTML missing assets
Medium Severity
The new root index.html links to styles.css and script.js, but neither file exists in the repository. Opening or serving that page leaves the to-do UI unstyled and without behavior.
Reviewed by Cursor Bugbot for commit 0f5c3d8. Configure here.
| run: deno lint | ||
|
|
||
| - name: Run tests | ||
| run: deno test -A |
There was a problem hiding this comment.
Deno CI on Node docs
Medium Severity
The Deno workflow runs deno lint and deno test -A on every main push and PR, but the repo has no deno.json and is built with npm/Docusaurus. Deno lint applies its own rules across the tree and is likely to fail or conflict with existing ESLint CI.
Reviewed by Cursor Bugbot for commit 0f5c3d8. Configure here.


Description
Issue(s) fixed
Fixes #
Preview
Checklist
External contributor checklist
Note
High Risk
New workflows on main/PRs can fail repeatedly (Deno, Gradle/zScan, incomplete SonarCloud/Codacy config) and the unrelated root index.html is confusing for a docs repo; only the devDependency bump is clearly intentional.
Overview
This PR adds four new GitHub Actions workflows on
mainpush/PR (and Codacy on a weekly cron): Codacy (SARIF upload, needsCODACY_PROJECT_TOKEN), SonarCloud (needsSONAR_TOKENand still has emptysonar.projectKey/sonar.organization), Deno (deno lint/deno test -A), and Zimperium zScan (./gradlew buildplus mobile APK placeholders andZSCAN_CLIENT_SECRET). Those jobs are largely stock templates and are unlikely to match this Docusaurus docs repo without extra setup, so they may fail or add noise on every run.It also adds a root
index.htmlto-do demo (referencesstyles.css/script.jsnot in the diff), a genericSECURITY.mdpolicy template, and bumps@typescript-eslint/parserfrom^8.46.2to^8.58.2inpackage.jsonwith a matchingpackage-lock.jsonrefresh.Reviewed by Cursor Bugbot for commit 0f5c3d8. Bugbot is set up for automated code reviews on this repo. Configure here.