fix(bitcoin): hide the origin row when there is nothing to display - #359
Merged
mikesposito merged 2 commits intoSep 24, 2026
Merged
Conversation
The PSBT-signing and send confirmations rendered the 'Request from' row unconditionally, so an origin with nothing meaningful to show (a WalletConnect connection id) produced a row with a blank value. Render the row only when displayOrigin resolves to a hostname or the MetaMask label, as the changelog already claims. Also stub .svg imports in the bitcoin Jest config (as the other snaps already do) so the JSX views, which transitively import network icons, can be tested directly.
mikesposito
marked this pull request as ready for review
September 24, 2026 10:50
mikesposito
force-pushed
the
me/origin/bitcoin-hide-origin-row
branch
from
September 24, 2026 11:53
69d05a5 to
1b1a689
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The PSBT-signing and send confirmations rendered the 'Request from' row unconditionally, so an origin with nothing meaningful to show (a WalletConnect connection id) produced a row with a blank value. Render the row only when displayOrigin resolves to a hostname or the MetaMask label, as the changelog already claims.
Also stub .svg imports in the bitcoin Jest config (as the other snaps already do) so the JSX views, which transitively import network icons, can be tested directly.
References
Checklist