fix(eth-json-rpc-middleware): validate typed-data keys on eth_signTypedData_v3 - #9810
Open
SashaMIT wants to merge 1 commit into
Open
fix(eth-json-rpc-middleware): validate typed-data keys on eth_signTypedData_v3#9810SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
…edData_v3 Parity with eth_signTypedData_v4: reject EIP-712 payloads that carry extraneous top-level keys before processTypedMessageV3 runs. Signed-off-by: Sasha Mitchell <sash.t.mitchell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eth_signTypedData_v4already callsvalidateTypedMessageKeysafter normalize;eth_signTypedData_v3skipped it.processTypedMessageV3.Test plan
should throw if message data contains extraneous keysundersignTypedDataV3@metamask/eth-json-rpc-middlewarejest suiteMade with Cursor