assets controllers deprecation#9014
Open
bergarces wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Low Risk
Annotation-only change with no runtime logic; low risk aside from IDE deprecation noise for consumers still on the old controllers.
Overview
Documents the migration from the legacy split assets stack to unified
AssetsControllerin@metamask/assets-controller.@metamask/assets-controllersadds a Deprecated changelog entry and applies a shared JSDoc@deprecatedtag across eleven legacy controllers:AccountTrackerController,CurrencyRateController,MultichainAssetsController,MultichainAssetsRatesController,MultichainBalancesController,RatesController,TokenBalancesController,TokenListController,TokenRatesController, andTokensController. Coverage includes exported state/types, messenger action types (including auto-generated*-method-action-typesfiles), and public instance methods.TokenListControllerpolling helpers (start,restart,stop,destroy, etc.) now use the same deprecation wording as the rest of the package instead of generic “new polling approach” notes.There is no functional or API behavior change in this PR—only TypeScript/editor deprecation surfacing and changelog documentation. The unreleased section also bumps
@metamask/network-enablement-controllerto^5.3.0.Reviewed by Cursor Bugbot for commit 3a09963. Bugbot is set up for automated code reviews on this repo. Configure here.