refactor: dedupe sentry trace#8994
Open
gambinish wants to merge 5 commits into
Open
Conversation
10 tasks
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7c35316. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Gaps to close (likely in the sibling client PRs, not core)
late_success/late_erroris the taxonomy used, rather thantimeoutso some dashboards may need to be updated.usePerpsMeasurement({ traceName: PerpsOrderSubmissionToast })fromusePerpsOrderExecution.ts, deleting the PerpsOrderSubmissionToast TraceName from app/util/trace.ts, and the mobile-side Promise.race.References
Checklist
Note
Medium Risk
Touches the order submission hot path and changes trace taxonomy (late_success/late_error vs prior UI timeout traces), but does not cancel in-flight orders or alter provider execution semantics.
Overview
Centralizes Perps Place Order Sentry tracing in
TradingService.placeOrderand drops the unusedPerps Order Submission Toasttrace name fromPerpsTraceName.Adds
PlaceOrderTimeoutMs(60s) as an observational threshold only: when the provider round-trip exceeds it, the service emits a warning breadcrumb and still awaitsprovider.placeOrderto completion (noPromise.race/ client-side cancel). Trace end data can includereason:late_success,late_error, orerror(including in the catch path after the threshold). Timers are cleared in success andfinally.New unit tests cover fast vs late success/error and timer cleanup. Changelog documents the behavior and the
late_errorcatch fix.Reviewed by Cursor Bugbot for commit 65f60c7. Bugbot is set up for automated code reviews on this repo. Configure here.