feat(wallet): wire TransactionController into default initialization#8975
Draft
matthewwalsh0 wants to merge 18 commits into
Draft
feat(wallet): wire TransactionController into default initialization#8975matthewwalsh0 wants to merge 18 commits into
matthewwalsh0 wants to merge 18 commits into
Conversation
matthewwalsh0
force-pushed
the
feat/wallet-wire-transaction-controller
branch
4 times, most recently
from
c3042bb to
9677e31
Compare
matthewwalsh0
added a commit
that referenced
this pull request
Jun 2, 2026
- Add `@metamask/transaction-controller` dependency - Add `transaction-controller/index.ts` initialization config; hardcodes `pendingTransactions` (both clients agree) and registers an RFC stub messenger so TC can call `RemoteFeatureFlagController:getState` at construction time - Expose `TransactionControllerInstanceOptions` (full TC options minus `messenger`, `pendingTransactions`, `state`) in `transaction-controller/types.ts` - Add `transactionController?` slot to `InstanceSpecificOptions` - Add tests, CODEOWNERS entry, README dependency graph edge, and CHANGELOG entry
…mprove TC messenger typing
…ify tests and changelog
…ing Wallet() calls
matthewwalsh0
force-pushed
the
feat/wallet-wire-transaction-controller
branch
from
58d79cc to
0069b11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adds
packages/wallet/src/initialization/instances/transaction-controller/following the same pattern established by theapproval-controller/directory in #8953.The directory contains:
transaction-controller.ts— theInitializationConfigurationthat wiresTransactionControllerinto the default wallet initialization, delegating messenger actions from the root and creating a typed child messenger for the controllertypes.ts—TransactionControllerInitMessenger,TransactionControllerInitMessengerActions,TransactionControllerInitMessengerEvents, andTransactionControllerInstanceOptions(a subset ofTransactionControllerOptionsthat exposes only the genuinely platform-specific options; shared defaults are hardcoded in the config)References
Checklist