fix(ramps-controller): remove nested widgetUrl field from Quote type #7881
+79
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The widgetUrl field was mistakenly added to the nested quote.quote object during initial development when the API format was incorrect. The API has been fixed to use a top-level url field instead. Changes: - Remove widgetUrl from nested quote object in Quote type - Simplify getWidgetUrl() to only check quote.url field - Update all tests to use top-level url field - Keep provider metadata types (providerInfo, features) added for API enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
During development of the quotes functionality in PR #7747, the
widgetUrlfield was mistakenly added to the nestedquote.quoteobject when the API format was still being finalized. The API has since been corrected to use a top-levelurlfield instead.This PR removes the incorrect nested structure before the quotes feature is released.
Changes
widgetUrlfrom the nestedquote.quoteobject in theQuotetypegetWidgetUrl()method to only check the top-levelquote.urlfieldurlfield instead of nestedwidgetUrlProviderType,ProviderFeatures, etc.) that were correctly addedReferences
Related to PR #7747
Note
Low Risk
Low risk type/shape cleanup: changes the
Quotecontract and widget URL extraction to usequote.url, so downstream consumers must align but behavior is straightforward and covered by updated tests.Overview
Fixes the quotes payload shape by removing the nested
quote.quote.widgetUrlfield and standardizing on a top-levelQuote.url.Updates
RampsController.getWidgetUrl()to readquote.urlonly, adjusts quote-related test fixtures accordingly, and expands the exported provider metadata typings (ProviderType,ProviderFeatures, etc.) viaRampsService/index.tsso callers can consume provider capability data embedded in quotes.Written by Cursor Bugbot for commit d2ebbf3. This will update automatically on new commits. Configure here.