feat: bump accounts deps + use new AccountProvider.createAccounts
#7857
+523
−216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ccharly
force-pushed
the
cc/feat/account-provider-createAccounts
branch
from
d367787 to
a425eca
Compare
ccharly
commented
Feb 9, 2026
| - **BREAKING:** Use new `AccountProvider.createAccounts` method with `CreateAccountOptions` ([#7857](https://github.com/MetaMask/core/pull/7857)) | ||
| - All account providers now accept `CreateAccountOptions` with `type` field. | ||
| - Added `capabilities` property to all account providers defining supported account creation types. | ||
| - **BREAKING:** Bump `@metamask/eth-snap-keyring` from `^18.0.0` to `^19.0.0` ([#7857](https://github.com/MetaMask/core/pull/7857)) |
Contributor
Author
There was a problem hiding this comment.
While not being used right now, I plan to use it right in a follow-up PR, and this would really become breaking at this point.
So, I just prefer to mark it as breaking right now, it feels more appropriate.
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
hmalik88
reviewed
Feb 9, 2026
hmalik88
previously approved these changes
Feb 9, 2026
ccharly
changed the title
AccountProvider.createAccountsaccounts deps + use new AccountProvider.createAccounts
Contributor
cryptodev-2s
left a comment
cryptodev-2s
left a comment
There was a problem hiding this comment.
Some minor suggestions otherwise looks good to me
Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
Co-authored-by: cryptodev-2s <109512101+cryptodev-2s@users.noreply.github.com>
cryptodev-2s
approved these changes
Feb 10, 2026
hmalik88
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Bumping all accounts deps.
AND:
Use of the new
createAccountsmethod (from the keyring V2 ADR).This will allow to slowly integrate new account creation constructors (such as the new
bip44:derive-index-rangeto batch account creations).References
N/A
Checklist
Note
Medium Risk
Touches core account creation/alignment paths and upgrades several keyring/account dependency majors, so runtime compatibility issues or mis-specified
CreateAccountOptions.typecould break account provisioning across providers.Overview
Updates
@metamask/*account/keyring dependencies across controllers (notably@metamask/account-apito^1.0.0,@metamask/keyring-apito^21.5.0,@metamask/keyring-internal-apito^10.0.0,@metamask/eth-snap-keyringto^19.0.0, and@metamask/keyring-snap-clientto^8.2.0), with correspondingCHANGELOGentries andyarn.lockrefresh.Refactors
multichain-account-serviceproviders to the newAccountProvider.createAccounts(options: CreateAccountOptions)signature by threading an explicittype(currentlyAccountCreationType.Bip44DeriveIndex) through wallet/group alignment and creation flows, adding per-providercapabilitiesmetadata, and validating supported creation types viaassertCreateAccountOptionIsSupported(with new negative tests).AccountProviderWrappernow forwardscapabilitiesand accepts the newCreateAccountOptionsshape.Minor tooling cleanup includes removing an obsolete ESLint suppression entry for
src/tests/providers.ts.Written by Cursor Bugbot for commit 3e0dd00. This will update automatically on new commits. Configure here.