chore: refactor permission rules and add additional validation#7844

Merged

jeffsmale90 merged 18 commits intomainfrom

chore/gator_permissions_decoding_adversarial_tests

Mar 6, 2026

Commits on Mar 5, 2026

Add adversarial tests for permission decoding. Add additional validation to ensure that permission data invariants are not violated.
jeffsmale90
committed
Refactor PermissionRule and rule generation so that each permission type is self-describing and can be more easily tested in isolation. Add validation and test coverage for each permission type.
jeffsmale90
committed
Linting fixes
jeffsmale90
committed
Adds validation for valueLte and exactCalldata caveats
jeffsmale90
committed
Each permission rule now derives it's internal enforcers type from the ChecksumEnforcersByChainId type rather than explicitly declaring a new type
jeffsmale90
committed
Add test to ensure that the GatorPermissionsController instantiates without specifying snapId
jeffsmale90
committed
Update GatorPermissionsController test to not instantiate controller twice
jeffsmale90
committed
Minor fixups:
jeffsmale90
committed
Add amountPerSecond validation to erc20tokenstream
jeffsmale90
committed
Trim whitespace
jeffsmale90
committed
Add missing validation to nativeTokenStream
jeffsmale90
committed
Remove unnecessary maxAmount validation (already indirectly validated). Add missing initialAmount validation.
jeffsmale90
committed
Don't inline the hexToBigInt when validating
jeffsmale90
committed
Remove isSubset and related tests
jeffsmale90
committed
Update rules:
jeffsmale90
committed
Remove redundant comment
jeffsmale90
committed
Remove erroneous initialAmount must be > 0 validation. correct validation comparing maxAmount and initialAmount.
jeffsmale90
committed

Commits on Mar 6, 2026

Remove newline
jeffsmale90
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: refactor permission rules and add additional validation#7844

chore: refactor permission rules and add additional validation#7844
jeffsmale90 merged 18 commits intomainfrom
chore/gator_permissions_decoding_adversarial_tests

Commits on Mar 5, 2026

Add adversarial tests for permission decoding. Add additional validation to ensure that permission data invariants are not violated.

Refactor PermissionRule and rule generation so that each permission type is self-describing and can be more easily tested in isolation. Add validation and test coverage for each permission type.

Linting fixes

Adds validation for valueLte and exactCalldata caveats

Each permission rule now derives it's internal enforcers type from the ChecksumEnforcersByChainId type rather than explicitly declaring a new type

Add test to ensure that the GatorPermissionsController instantiates without specifying snapId

Update GatorPermissionsController test to not instantiate controller twice

Minor fixups:

Add amountPerSecond validation to erc20tokenstream

Trim whitespace

Add missing validation to nativeTokenStream

Remove unnecessary maxAmount validation (already indirectly validated). Add missing initialAmount validation.

Don't inline the hexToBigInt when validating

Remove isSubset and related tests

Update rules:

Remove redundant comment

Remove erroneous initialAmount must be > 0 validation. correct validation comparing maxAmount and initialAmount.

Commits on Mar 6, 2026

Remove newline