Skip to content

Conversation

@baptiste-marchand
Copy link
Contributor

@baptiste-marchand baptiste-marchand commented Feb 4, 2026

Explanation

This PR removes notification networks config to replace it by backend data.
Backend PR: https://github.com/consensys-vertical-apps/va-mmcx-notify-notification-services/pull/265

References

Fixes: GE-23

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Introduces a breaking export removal and changes how push notification text derives chain symbols, so clients must adapt and backend payloads must reliably include payload.network.

Overview
Moves notification network metadata from client-side constants to backend-provided payload fields. The ./notification-services/ui subpath export (and its bundled network constants/types like NOTIFICATION_CHAINS_ID, currency symbols, and block explorer mappings) is removed, and the root NotificationServicesController no longer re-exports UI.

Notification API types are updated so on-chain payloads include network metadata (native_symbol, block_explorer, etc.), mocks are updated to include this new payload.network object, and push-notification message generation now reads the symbol from notification.payload.network.native_symbol instead of local chain-id mappings.

Written by Cursor Bugbot for commit d01b2f9. This will update automatically on new commits. Configure here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM!!

Great that we can clean this up!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note - this whole file can be thrown away once we start the push notification cleanup ticket
(push notifications are all derived from the server now, so we do not need any client side implementation to generate push messages).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 6e7ebdb. I thought it made sense to add it in this PR

@baptiste-marchand baptiste-marchand changed the title [GE-23] feat: move Notifications networks config to backend feat: move Notifications networks config to backend [GE-23] Feb 5, 2026
@baptiste-marchand baptiste-marchand marked this pull request as ready for review February 9, 2026 10:04
@baptiste-marchand baptiste-marchand requested review from a team as code owners February 9, 2026 10:04
- Note, however, that the versions specified in the client's `package.json` always "win", and you are expected to keep them up to date so as not to break controller and service intercommunication.
- Modified background push utilities to handle more edgecases and not throw errors ([#7275](https://github.com/MetaMask/core/pull/7275))
- Bump `@metamask/controller-utils` from `^11.16.0` to `^11.18.0` ([#7534](https://github.com/MetaMask/core/pull/7534), [#7583](https://github.com/MetaMask/core/pull/7583))
- Move Notifications networks metadata to backend ([#7840](https://github.com/MetaMask/core/pull/7840))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are removing some exports, lets add this in the ### Removed section, and mark as breaking (will require a major version bump)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants