-
-
Notifications
You must be signed in to change notification settings - Fork 275
feat: move Notifications networks config to backend [GE-23] #7840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: move Notifications networks config to backend [GE-23] #7840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TYSM!!
Great that we can clean this up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note - this whole file can be thrown away once we start the push notification cleanup ticket
(push notifications are all derived from the server now, so we do not need any client side implementation to generate push messages).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 6e7ebdb. I thought it made sense to add it in this PR
...ation-services-controller/src/NotificationServicesController/mocks/mock-raw-notifications.ts
Show resolved
Hide resolved
packages/notification-services-controller/notification-services/ui/package.json
Outdated
Show resolved
Hide resolved
...tion-services-controller/src/NotificationServicesController/constants/notification-schema.ts
Show resolved
Hide resolved
| - Note, however, that the versions specified in the client's `package.json` always "win", and you are expected to keep them up to date so as not to break controller and service intercommunication. | ||
| - Modified background push utilities to handle more edgecases and not throw errors ([#7275](https://github.com/MetaMask/core/pull/7275)) | ||
| - Bump `@metamask/controller-utils` from `^11.16.0` to `^11.18.0` ([#7534](https://github.com/MetaMask/core/pull/7534), [#7583](https://github.com/MetaMask/core/pull/7583)) | ||
| - Move Notifications networks metadata to backend ([#7840](https://github.com/MetaMask/core/pull/7840)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are removing some exports, lets add this in the ### Removed section, and mark as breaking (will require a major version bump)
Explanation
This PR removes notification networks config to replace it by backend data.
Backend PR: https://github.com/consensys-vertical-apps/va-mmcx-notify-notification-services/pull/265
References
Fixes: GE-23
Checklist
Note
Medium Risk
Introduces a breaking export removal and changes how push notification text derives chain symbols, so clients must adapt and backend payloads must reliably include
payload.network.Overview
Moves notification network metadata from client-side constants to backend-provided payload fields. The
./notification-services/uisubpath export (and its bundled network constants/types likeNOTIFICATION_CHAINS_ID, currency symbols, and block explorer mappings) is removed, and the rootNotificationServicesControllerno longer re-exportsUI.Notification API types are updated so on-chain payloads include
networkmetadata (native_symbol,block_explorer, etc.), mocks are updated to include this newpayload.networkobject, and push-notification message generation now reads the symbol fromnotification.payload.network.native_symbolinstead of local chain-id mappings.Written by Cursor Bugbot for commit d01b2f9. This will update automatically on new commits. Configure here.