-
-
Notifications
You must be signed in to change notification settings - Fork 275
refactor(ramps): streamline RampsController reset and abort logic #7818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
georgeweiler
wants to merge
38
commits into
main
Choose a base branch
from
ramps-loading-state-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+287
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Refactors region-dependent reset behavior into a single helper and improves abort handling so dependent resources stay in sync.
Changes
DEPENDENT_RESOURCE_KEYSandresetResource()so "reset one resource" is defined once and driven bygetDefaultRampsControllerState().resetDependentResources()to callgetDefaultRampsControllerState()once and loop over the keys instead of many manual assignments.resetResource(state, 'paymentMethods')insetSelectedProviderandsetSelectedTokenso payment methods are fully reset (includingisLoadinganderror), fixing stale loading/error state when changing or clearing provider/token.Draft<RampsControllerState>so they can be used insideupdate()without casts and avoid TS2589.Result
Single source of truth for default/reset state, less duplicated code, and correct clearing of
paymentMethods(and optionallyquotes.selected) on region or selection changes.References
Checklist
Note
Medium Risk
Touches shared request-caching/abort and state-reset paths that affect providers/tokens/payment-methods/quotes flows; regressions could surface as stale loading/error state or incorrect request cancellation behavior.
Overview
Consolidates region-dependent state resets behind a shared
resetResourcehelper (driven bygetDefaultRampsControllerState) and reuses it fromresetDependentResources,setSelectedProvider, andsetSelectedTokento fully clear dependentpaymentMethodsstate (includingisLoading/error).Improves request tracking by storing
resourceTypeon pending requests and clarifiesexecuteRequestbehavior around deduplication/cache hits/loading/error updates, plus adds defensive handling forgetCountries()to only persist array results. Test coverage is updated to assert the new reset semantics, defensive countries behavior, and cache-expiration behavior for non-success states; changelog entry added.Written by Cursor Bugbot for commit 1d6331d. This will update automatically on new commits. Configure here.