chore: update release action #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if: github.event_name == 'push' && startsWith(github.event.head_commit.author.name, 'github-actions') | ||
| name: Determine whether this is a release merge commit | ||
| needs: all-jobs-pass | ||
| if: github.event_name == 'push' |
There was a problem hiding this comment.
Removed commit author check weakens release trigger security
Medium Severity
The is-release job's if condition removed the startsWith(github.event.head_commit.author.name, 'github-actions') guard that previously ensured only commits authored by the github-actions bot (from the create-release-pr workflow) could trigger a release. Now any push to main is evaluated by action-is-release@v2, so a contributor could craft a PR (e.g., bumping package.json version or matching the commit message pattern) and trigger a release upon merge. As noted in the PR discussion, this reduces defense-in-depth around the release pipeline.
NicholasEllul
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk CI-only change; main risk is unintended releases or missed publishes if the new
is-releaseconditions/action output differ from v1.Overview
Updates the
is-releasegate in.github/workflows/main.ymlto useMetaMask/action-is-release@v2and renames the job for clarity.Release detection is now run on all
pushevents (instead of additionally filtering by commit author), relying on the action’sIS_RELEASEoutput to decide whether to runpublish-release.Written by Cursor Bugbot for commit 39a48a0. This will update automatically on new commits. Configure here.