chore(port): drop PORT_STATUS.toml inventory in favor of port-and-delete#1351
Merged
mergify[bot] merged 1 commit intomainfrom May 6, 2026
Conversation
Member
Author
|
This pull request is part of a Mergify stack:
|
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
There was a problem hiding this comment.
Pull request overview
Removes the explicit Python↔Rust port inventory (PORT_STATUS.toml) and its guard test, and replaces that “anti-drift” guidance with documented process in AGENTS.md (“port-and-delete” rule).
Changes:
- Deleted
PORT_STATUS.tomlcommand inventory. - Removed
mergify_cli/tests/test_port_status.pythat enforced inventory ↔ click-tree parity. - Documented the “port in Rust + delete Python in same PR” workflow in
AGENTS.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
PORT_STATUS.toml |
Removed the port inventory file entirely. |
mergify_cli/tests/test_port_status.py |
Removed the test suite that validated the inventory against the Python click command tree. |
AGENTS.md |
Added a “Rust Port Workflow” section to preserve the intended anti-drift contract after dropping the inventory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
103418f to
9889d7e
Compare
Member
Author
Revision history
|
9889d7e to
549a14d
Compare
This was referenced May 5, 2026
Base automatically changed from
devs/jd/worktree-rust-port/validate-sdist-wheel-metadata-twine-pr--0f7338df
to
main
May 5, 2026 12:31
549a14d to
857f9fc
Compare
Status was implicit: every entry was `shimmed`, and ports flip status by deleting the entry (because the Python copy is removed in the same PR). Tracking that in TOML adds a step that does no work — the truth is "command exists in click → shimmed; doesn't → ported or never existed." Drop the inventory file plus its guard test; document the port-and-delete rule in AGENTS.md so the structural anti-drift contract survives losing the file's header comment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Change-Id: I77522cb91d59b41815a98869953bff331ede3941
857f9fc to
10698c0
Compare
remyduthu
approved these changes
May 6, 2026
JulianMaurin
approved these changes
May 6, 2026
Contributor
Merge Queue Status
This pull request spent 15 minutes 56 seconds in the queue, including 13 minutes 52 seconds running CI. Required conditions to merge
|
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status was implicit: every entry was
shimmed, and ports flip statusby deleting the entry (because the Python copy is removed in the same
PR). Tracking that in TOML adds a step that does no work — the truth
is "command exists in click → shimmed; doesn't → ported or never
existed."
Drop the inventory file plus its guard test; document the
port-and-delete rule in AGENTS.md so the structural anti-drift
contract survives losing the file's header comment.
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com