Skip to content

chore(port): drop PORT_STATUS.toml inventory in favor of port-and-delete#1351

Merged
mergify[bot] merged 1 commit intomainfrom
devs/jd/worktree-rust-port/drop-port-status-toml-inventory-favor-port-delete--77522cb9
May 6, 2026
Merged

chore(port): drop PORT_STATUS.toml inventory in favor of port-and-delete#1351
mergify[bot] merged 1 commit intomainfrom
devs/jd/worktree-rust-port/drop-port-status-toml-inventory-favor-port-delete--77522cb9

Conversation

@jd
Copy link
Copy Markdown
Member

@jd jd commented May 5, 2026

Status was implicit: every entry was shimmed, and ports flip status
by deleting the entry (because the Python copy is removed in the same
PR). Tracking that in TOML adds a step that does no work — the truth
is "command exists in click → shimmed; doesn't → ported or never
existed."

Drop the inventory file plus its guard test; document the
port-and-delete rule in AGENTS.md so the structural anti-drift
contract survives losing the file's header comment.

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

Copilot AI review requested due to automatic review settings May 5, 2026 09:39
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 5, 2026 09:39 Failure
@jd
Copy link
Copy Markdown
Member Author

jd commented May 5, 2026

This pull request is part of a Mergify stack:

# Pull Request Link
1 chore(port): drop PORT_STATUS.toml inventory in favor of port-and-delete #1351 👈
2 docs(port): add port review checklist for HTTP/test/UX parity pitfalls #1357
3 feat(rust): add mergify_core::auth with gh and git-config fallbacks #1364
4 feat(rust): port queue pause and unpause to native Rust #1352
5 feat(rust): port ci git-refs and ci queue-info to native Rust #1353
6 feat(rust): port queue status to native Rust #1359
7 test: derive native queue commands from the binary, not a hardcoded list #1366

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 5, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the explicit Python↔Rust port inventory (PORT_STATUS.toml) and its guard test, and replaces that “anti-drift” guidance with documented process in AGENTS.md (“port-and-delete” rule).

Changes:

  • Deleted PORT_STATUS.toml command inventory.
  • Removed mergify_cli/tests/test_port_status.py that enforced inventory ↔ click-tree parity.
  • Documented the “port in Rust + delete Python in same PR” workflow in AGENTS.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
PORT_STATUS.toml Removed the port inventory file entirely.
mergify_cli/tests/test_port_status.py Removed the test suite that validated the inventory against the Python click command tree.
AGENTS.md Added a “Rust Port Workflow” section to preserve the intended anti-drift contract after dropping the inventory.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread AGENTS.md Outdated
Comment thread AGENTS.md Outdated
@mergify mergify Bot requested a review from a team May 5, 2026 09:50
@jd jd force-pushed the devs/jd/worktree-rust-port/drop-port-status-toml-inventory-favor-port-delete--77522cb9 branch from 103418f to 9889d7e Compare May 5, 2026 10:12
@jd jd changed the base branch from main to devs/jd/worktree-rust-port/bundle-license-wheel-sdist--e4571775 May 5, 2026 10:12
@jd
Copy link
Copy Markdown
Member Author

jd commented May 5, 2026

Revision history

# Type Changes Reason Date
1 initial 103418f 2026-05-05 10:12 UTC
2 rebase 103418f → 9889d7e 2026-05-05 10:12 UTC
3 content 9889d7e → 549a14d 2026-05-05 10:19 UTC
4 rebase 549a14d → 857f9fc 2026-05-05 13:13 UTC
5 rebase 857f9fc → 10698c0 2026-05-05 19:59 UTC

@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 5, 2026 10:12 Failure
@jd jd force-pushed the devs/jd/worktree-rust-port/drop-port-status-toml-inventory-favor-port-delete--77522cb9 branch from 9889d7e to 549a14d Compare May 5, 2026 10:19
@jd jd changed the base branch from devs/jd/worktree-rust-port/bundle-license-wheel-sdist--e4571775 to devs/jd/worktree-rust-port/validate-sdist-wheel-metadata-twine-pr--0f7338df May 5, 2026 10:19
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 5, 2026 10:19 Failure
@jd jd marked this pull request as ready for review May 5, 2026 10:25
Base automatically changed from devs/jd/worktree-rust-port/validate-sdist-wheel-metadata-twine-pr--0f7338df to main May 5, 2026 12:31
@jd jd force-pushed the devs/jd/worktree-rust-port/drop-port-status-toml-inventory-favor-port-delete--77522cb9 branch from 549a14d to 857f9fc Compare May 5, 2026 13:13
@mergify mergify Bot had a problem deploying to Mergify Merge Protections May 5, 2026 13:13 Failure
Status was implicit: every entry was `shimmed`, and ports flip status
by deleting the entry (because the Python copy is removed in the same
PR). Tracking that in TOML adds a step that does no work — the truth
is "command exists in click → shimmed; doesn't → ported or never
existed."

Drop the inventory file plus its guard test; document the
port-and-delete rule in AGENTS.md so the structural anti-drift
contract survives losing the file's header comment.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Change-Id: I77522cb91d59b41815a98869953bff331ede3941
@jd jd force-pushed the devs/jd/worktree-rust-port/drop-port-status-toml-inventory-favor-port-delete--77522cb9 branch from 857f9fc to 10698c0 Compare May 5, 2026 19:58
@mergify mergify Bot deployed to Mergify Merge Protections May 5, 2026 19:59 Active
@mergify mergify Bot requested a review from a team May 6, 2026 07:55
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 6, 2026

Merge Queue Status

This pull request spent 15 minutes 56 seconds in the queue, including 13 minutes 52 seconds running CI.

Required conditions to merge

mergify Bot added a commit that referenced this pull request May 6, 2026
@mergify mergify Bot added the queued label May 6, 2026
@mergify mergify Bot merged commit 43b904c into main May 6, 2026
34 checks passed
@mergify mergify Bot deleted the devs/jd/worktree-rust-port/drop-port-status-toml-inventory-favor-port-delete--77522cb9 branch May 6, 2026 08:49
@mergify mergify Bot removed the queued label May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants